Allow renaming database elements from table list #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@azmy60 Is this good for review? Looks like you still have some TODOs undone? |
|
@rathboma Yes. I was looking into the tests on renaming routines but somehow they don't work except when I tested it in app manually. It's good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to table list context menu to rename database elements. This includes:
renameif the database doesn't support itawait this.$confirm(can't help but this needed improvements, even though it's not on the ticket lol)close #2114
TODO:
Rename routines(blocked: automation tests don't like it. I'm only able to test this manually.)setElementName()just in BasicDatabaseClient