Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix building primary key with autoincrement #2185

Merged
merged 3 commits into from
May 15, 2024

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented May 7, 2024

Based on this issue #2180 , the video shows that editing is disabled due to the lack of primary key, not after adding an enum column. It's disabled even before adding an enum column.

But after testing the table builder, I found that creating a column as a pk with autoincrement doesn't make the column pk. Thus the editing was disabled in the first place.

Note: There's no auto increment functionality for a PK in BigQuery and Cassandra DBs.

close #2180

}],
}
const query = generator.buildSql(schema)
const expectedQueries = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we're expecting something different per-dialect, these should just go directly in the driver tests, but it's fine for now

@rathboma rathboma merged commit 7e695c4 into master May 15, 2024
13 checks passed
@rathboma rathboma deleted the fix/autoincrement-pk-table-builder branch May 15, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Adding an enum to a table disables editing
2 participants