Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info to indexes to show nulls not distinct in Postgres 15 #2188

Merged
merged 2 commits into from
May 15, 2024

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented May 8, 2024

fix #2115

image


🚀 This description was created by Ellipsis for commit 141cb3b

Summary:

This PR adds UI support for displaying 'NULLS NOT DISTINCT' information for indexes in PostgreSQL 15 and above, enhancing detail provided about database indexes.

Key points:

  • Add support for displaying 'NULLS NOT DISTINCT' for indexes in PostgreSQL 15+.
  • Modify TableIndexes.vue to include this info based on DB version.
  • Update PostgresClient to fetch this data when listing indexes.
  • Update SupportedFeatures model to include a flag for this feature.
  • Ensure feature availability only for PostgreSQL versions 15 and above.

Generated with ❤️ by ellipsis.dev

@rathboma
Copy link
Collaborator

rathboma commented May 10, 2024

@ellipsis-dev code review?

Copy link
Contributor

ellipsis-dev bot commented May 10, 2024

OK! Reviewing this PR...


Responding to this comment by @rathboma. For more information about Ellipsis, check the documentation.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 141cb3b in 2 minutes and 41 seconds

More details
  • Looked at 289 lines of code in 13 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. apps/studio/src/lib/db/clients/postgresql.ts:409
  • Draft comment:
    The conditional inclusion of 'indnullsnotdistinct' in the SELECT statement based on the Postgres version is a good approach. However, ensure that the version comparison logic (this.version.number >= 150_000) accurately reflects the versioning scheme used by Postgres and that it is tested thoroughly to handle edge cases around version boundaries.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection.

Workflow ID: wflow_xedrEaso5gNj7Kuj


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

6 days left in your free trial, upgrade for $20/seat/month or contact us.

@rathboma rathboma merged commit 932803e into master May 15, 2024
13 checks passed
@rathboma rathboma deleted the fix/nulls-not-distinct branch May 15, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: PSQL 15+ indexes don't display when NULLS NOT DISTINCT” option was turned on
2 participants