Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [Ellipsis] Copy as Sql #2193

Closed
wants to merge 1 commit into from

Conversation

ellipsis-dev[bot]
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot commented May 10, 2024

⚠️ Sorry, I timed out before I could complete this PR, so I've submitted my work in progress.

Summary:

⚠️ We couldn't build/test your project to verify our changes. Add a Dockerfile to significantly improve code quality.

Issue: resolves #2174

Implementation:

Step 1: Modify the listTableColumns method to return columns in table column order

In the BasicDatabaseClient class, modify the listTableColumns method to return the columns in the order they appear in the table. This might involve changing the SQL query used to retrieve the columns or sorting the columns after they are retrieved. Make sure to check the function definition in other subclasses as well, as the behavior of the listTableColumns method might be different in different subclasses.

Step 2: Modify the buildInsertQuery function to generate SQL in table column order

Modify the buildInsertQuery function to generate the SQL insert query in the order of the columns passed to the function. Since the listTableColumns method has been modified to return the columns in table column order, the buildInsertQuery function should now generate the SQL insert query in table column order.

Step 3: Update the getInsertQueryTests in runCommonTests to test the fix

Update the getInsertQueryTests in runCommonTests to test if the SQL query generated by getInsertQuery is in table column order. This might involve modifying the expected SQL queries in the test to be in table column order and checking if the actual SQL query generated by getInsertQuery matches the expected query.

Report:

Step Result Details
1
Modify the listTableColumns method to return columns in table column orderNo result
2
Modify the buildInsertQuery function to generate SQL in table column orderNo result
3
Update the getInsertQueryTests in runCommonTests to test the fixNo result

Something look wrong?: If this Pull Request doesn't contain the expected changes, add more information to #2174. Then, try again. For more information, check the documentation.

@rathboma rathboma closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy as Sql
1 participant