Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on web-vitals 2.x #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laradevitt
Copy link

This is a PR for Update web-vitals dependency to 2.x branch #5

With this update there is a breaking change as described in the PR Update CLS to max session window 5s cap 1s gap #148:

The only observable difference developers might notice to the API is previously the metric.entries array would only ever add new entries as additional shifts occurred on the page. With this change, only the entries from the max session window are reported, which means it could be the case the some of the entries referenced when CLS is first reported (e.g. after the tab is backgrounded), may not be the entries that are referenced the next time the tab is backgrounded. Developers not referencing the metric.entries array should not notice any differences other than a possible reduction in the value reported.

AFAICT this plugin only references the performance entry of the TTFB metric to calculate request time so I'm fairly confident this plugin would be unaffected by the breaking change but a proper review is obviously in order.

Thanks!

@laradevitt
Copy link
Author

Wups - Would actually be updating from web-vitals ^0.2.1 (not 1.x) so it might take a bit more work to bring this plugin up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant