Issue #122: Alerts unit bug fix #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktrz
reviewed
Apr 25, 2024
Comment on lines
+583
to
+584
| const prevMs = toMs(prev.value, prev.unit); | ||
| const currentMs = toMs(current.value, current.unit); |
There was a problem hiding this comment.
Not all benchmarks are output results in units of time and this logic will apply to all of them which would basically output 0 for all benchmarks that don't use us, ms or s as unit
ktrz
reviewed
Apr 25, 2024
ktrz
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Thank you for your contribution! I've added some comments.
Additionally, I ran tests and linting on your PR and they both fail. Please remember that all existing tests and linting should pass before the PR can be merged.
One more thing. Could you please add some test cases that cover the issue that this is fixing?
Co-authored-by: Chris Trześniewski <k.trzesniewski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
Results are now accordingly normalized to miliseconds before calculating their ratio, for alerts and threshold to work on results which use different units.