Proposal to Replace Deprecated TSLint with ESLint, Prettier #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing this! Getting the tooling up to date would be wonderful, and I should have some time to review this evening. |
bencompton
approved these changes
Mar 23, 2024
|
I'm good with the tools you've introduced here and am also up for trying out your OSS dev-tools project. If you wouldn't mind getting the conflicts resolved (from merging your other PR), we can get this one merged as well. Thanks again! |
|
Hello, I'm rebasing my branch to correct the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am proposing a significant change to our codebase. As TSLint is now deprecated, I suggest we replace it with ESLint and Prettier. I have used my personal configurations which are quite strict. However, I am open to discussion if there are any concerns or suggestions.
In addition, I have added Husky to our project. Husky will automatically run
eslint --fixon every new file during the pre-commit hook. This will ensure that our code remains clean and adheres to our coding standards.Please review these changes and provide your feedback.
Best.