Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm to publish package #204

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

pplancq
Copy link
Contributor

@pplancq pplancq commented Mar 25, 2024

The github action you set up https://github.com/pascalgn/npm-publish-action/blob/master/Dockerfile uses version 12 of node with yarn 1.

So I wonder if yarn isn't causing the problem because it's used by default.

So I've configured it to use npm as you were able to use it locally without any problems, which should work, or so I hope.

I'm really sorry for all the problems, it's the first time that using husky has caused me problems.

As a last resort we could temporarily remove husky until we find a permanent solution.

@bencompton bencompton merged commit 6149d18 into bencompton:master Mar 25, 2024
2 checks passed
@bencompton
Copy link
Owner

bencompton commented Mar 25, 2024

Still no luck. NPM is rate limiting it now for some reason: npm ERR! 429 Too Many Requests - PUT https://registry.npmjs.org/jest-cucumber. I initially thought this was because I fired off 2 workflows in quick succession, but it still produces the same error after waiting 30 minutes.

No worries about the issues--it might be something to do with pascalgn/npm-publish-action like you said. I was just trying to get something working quickly and didn't take the time to properly vet it. I'm good with focusing on semantic-release instead of spending more time on this if you'd prefer, since running npm publish locally works fine in the meantime.

@pplancq pplancq deleted the bugfix/publishAction branch March 25, 2024 17:25
@pplancq
Copy link
Contributor Author

pplancq commented Mar 25, 2024

I understand, I'll see if I can find you a simple solution to release faster and more efficiently.
Just to make sementic-release work properly could you just add a git tag v4.0.10 on your last commit.
I'll finish my pr #200 with commitlint and then I'll propose a clean workflow with semantic-release.
I don't mind, I like to mess around with workflows.

@bencompton
Copy link
Owner

I'm grateful for all of your efforts help modernize and streamline this project, and looking forward to your next PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants