Tolerate undeclared exports until @babel/parser@7.5.0 is released. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babel/babel#9864 This hack narrowly targets @babel/parser@7.4.x by tricking Array.from(this.scope.undefinedExports) into returning an empty array, thereby simulating the effect of enabling the allowUndeclaredExports option (which will become available in @babel/parser@7.5.0).
benjamn
added a commit
to meteor/babel
that referenced
this pull request
Jun 20, 2019
benjamn
added a commit
to meteor/babel
that referenced
this pull request
Jun 20, 2019
Similar in spirit to benjamn/reify#230.
benjamn
added a commit
that referenced
this pull request
Jul 4, 2019
After updating @babel/parser to version 7.5.0, I can verify that the monkey-patching changes in PR #230 are no longer necessary, though it doesn't hurt to leave them in place, since the interception logic is restricted to versions in the 7.4.x range. The allowUndeclaredExports option is now required, as anticipated: babel/babel#9864
benjamn
added a commit
to meteor/babel
that referenced
this pull request
Jul 4, 2019
Now that @babel/parser@7.5.0 is out, we no longer need to simulate the effect of babel/babel#9864. See also benjamn/reify#230.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround until this PR is released: babel/babel#9864
This hack narrowly targets
@babel/parser@7.4.xby trickingArray.from(this.scope.undefinedExports)into returning an empty array, thereby simulating the effect of enabling theallowUndeclaredExportsoption (which will become available in@babel/parser@7.5.0).