Merge remote-tracking branch 'upstream/master' into 8.x

integration/side-effects/snapshots/esm/ajax.js

@@ -1 +1 @@
-
+const _bind = Function.prototype.bind;

integration/side-effects/snapshots/esm/fetch.js

@@ -1 +1,3 @@
-import "tslib";
+import 'tslib';
+
+const _bind = Function.prototype.bind;

integration/side-effects/snapshots/esm/index.js

@@ -1 +1,3 @@
-import "tslib";
+import 'tslib';
+
+const _bind = Function.prototype.bind;

integration/side-effects/snapshots/esm/operators.js

@@ -1 +1,3 @@
-import "tslib";
+import 'tslib';
+
+const _bind = Function.prototype.bind;

integration/side-effects/snapshots/esm/testing.js

@@ -1 +1 @@
-
+const _bind = Function.prototype.bind;

integration/side-effects/snapshots/esm/websocket.js

@@ -1 +1 @@
-
+const _bind = Function.prototype.bind;

integration/side-effects/snapshots/esm5/ajax.js

@@ -1 +1,3 @@
-import "tslib";
+import 'tslib';
+
+var _bind = Function.prototype.bind;

integration/side-effects/snapshots/esm5/fetch.js

@@ -1 +1,3 @@
-import "tslib";
+import 'tslib';
+
+var _bind = Function.prototype.bind;

integration/side-effects/snapshots/esm5/index.js

@@ -1 +1,3 @@
-import "tslib";
+import 'tslib';
+
+var _bind = Function.prototype.bind;

integration/side-effects/snapshots/esm5/operators.js

@@ -1 +1,3 @@
-import "tslib";
+import 'tslib';
+
+var _bind = Function.prototype.bind;

integration/side-effects/snapshots/esm5/testing.js

@@ -1 +1,3 @@
-import "tslib";
+import 'tslib';
+
+var _bind = Function.prototype.bind;

integration/side-effects/snapshots/esm5/websocket.js

@@ -1 +1,3 @@
-import "tslib";
+import 'tslib';
+
+var _bind = Function.prototype.bind;

spec/Observable-spec.ts

@@ -172,6 +172,34 @@ describe('Observable', () => {
   });
 
   describe('subscribe', () => {
+    it('should work with handlers with hacked bind methods', () => {
+      const source = of('Hi');
+      const results: any[] = [];
+      const next = function (value: string) {
+        results.push(value);
+      }
+      next.bind = () => { /* lol */};
+
+      const complete = function () {
+        results.push('done');
+      }
+      complete.bind = () => { /* lol */};
+
+      source.subscribe({ next, complete });
+      expect(results).to.deep.equal(['Hi', 'done']);
+    });
+
+    it('should work with handlers with hacked bind methods, in the error case', () => {
+      const source = throwError(() => 'an error');
+      const results: any[] = [];
+      const error = function (value: string) {
+        results.push(value);
+      }
+
+      source.subscribe({ error });
+      expect(results).to.deep.equal(['an error']);
+    });
+
     it('should be synchronous', () => {
       let subscribed = false;
       let nexted: string;

src/internal/Subscriber.ts

@@ -135,6 +135,17 @@ export class Subscriber<T> extends Subscription implements Observer<T> {
   }
 }
 
+/**
+ * This bind is captured here because we want to be able to have
+ * compatibility with monoid libraries that tend to use a method named
+ * `bind`. In particular, a library called Monio requires this.
+ */
+const _bind = Function.prototype.bind;
+
+function bind<Fn extends (...args: any[]) => any>(fn: Fn, thisArg: any): Fn {
+  return _bind.call(fn, thisArg);
+}
+
 export class SafeSubscriber<T> extends Subscriber<T> {
   constructor(observerOrNext?: Partial<Observer<T>> | ((value: T) => void) | null) {
     super();
@@ -152,9 +163,10 @@ export class SafeSubscriber<T> extends Subscriber<T> {
       // going to put them all in a new destination with ensured methods
       // for `next`, `error`, and `complete`. That's part of what makes this
       // the "Safe" Subscriber.
-      next = observerOrNext.next?.bind(observerOrNext);
-      error = observerOrNext.error?.bind(observerOrNext);
-      complete = observerOrNext.complete?.bind(observerOrNext);
+      ({ next, error, complete } = observerOrNext);
+      next = next && bind(next, observerOrNext);
+      error = error && bind(error, observerOrNext);
+      complete = complete && bind(complete, observerOrNext);
     }
 
     // Once we set the destination, the superclass `Subscriber` will