[Fix] order: Fix alphabetize for mixed requires and imports
#1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
ljharb
approved these changes
Feb 2, 2020
ljharb
force-pushed
the
fix-alphabetize
branch
from
29ad3bb
to
5d00854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1625
Overview
The ranks of require items (which are +100) were being lost due to the algorithm not using the group rank when recalculating the alphabetized ranks.
To fix this, make the alphabetized rank of the item the group rank plus the alphabetization rank.
Test Plan
Run new unit tests. Before the change the tests would fail. After the change the tests pass.