[eslint-config-universe] Add import ordering alphabetization #7038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
requested review from
bbarthec,
brentvatne,
esamelson,
EvanBacon,
lukmccall,
mczernek,
sjchmiela and
tsapeta
as code owners
ide
reviewed
Feb 12, 2020
wschurman
force-pushed
the
@wschurman/upstream-import-ordering
branch
from
e842d4b
to
f27e09d
Compare
ide
approved these changes
Feb 14, 2020
wschurman
force-pushed
the
@wschurman/upstream-import-ordering
branch
from
f27e09d
to
9e42dc4
Compare
|
Published eslint-config-universe@2.3.0 to npm. |
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
gurs1kh
pushed a commit
to gurs1kh/expo
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This is the second part of #6847. Since import-js/eslint-plugin-import#1626 was merged and released in 2.20.1, we can now pull it into the
esling-config-universepackage.How
expotools check-packages --no-build --no-test --fix-lint(commit 2)expotools check-packages --no-build --no-testand manually fix lint errors, updating config as well to exclude .d.ts files for the rule since they have weird import semantics (can import inside declare block). (commit 3)expotools check-packagesto rebuild the files. (commit 4)babel-preset-expopackage. (commit 5)Test Plan
expotools check-packages