Update sock.py by making bind list creation more readable #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing suggestion by reviewer benoitc#3127 (comment) to make code more readable.
pajod
reviewed
May 21, 2024
Comment on lines
+90
to
+91
| bind_list = [bind for bind in conf.address if not isinstance(bind, int)] | ||
| for addr in bind_list: |
There was a problem hiding this comment.
Now it just looks less like its sister list comprehension above. I do not see the improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing suggestion by reviewer #3127 (comment) to make code more readable.