Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.1 deprecation notices #428

Open
wants to merge 1 commit into
base: 0.x
Choose a base branch
from

Conversation

AdrienPoupa
Copy link

@AdrienPoupa AdrienPoupa commented Dec 14, 2022

This fixes the deprecation notices reported in #425 by specifying the int return type for the count functions.

Initially I wanted to use the master branch but it is lacking the Predis driver that we use.

I figured this would be more inclusive than using #[\ReturnTypeWillChange] given we only need to bump to PHP7 or higher and not PHP8.

Since this removes support for PHP5 (about time I guess? :)) I would suggest to release this as 0.14.0.

@petaritekako
Copy link

Hi guys,
when this will be merged and created new release?
We are using this package in our project and we also have this deprecation notice.

@holtkamp
Copy link
Contributor

@sagikazarmark any way the community can help with this?

@kibertoad
Copy link

@sagikazarmark ping? can you give any update on the status of the project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants