Add tsd for type declaration tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this! Unfortunately, I'm currently away from my "production environment" on vacation so I can't really check it out until next Tuesday. I'll check this out and read more carefully and reply to your other comments in #13 at that time. Thanks again for your help! |
|
@berniegp no worries, enjoy your holiday ! |
berniegp
approved these changes
Aug 19, 2019
| @@ -50,10 +52,21 @@ | |||
| "rollup": "^1.16.4", | |||
| "rollup-plugin-buble": "^0.19.8", | |||
| "rollup-plugin-replace": "^2.2.0", | |||
| "typescript": "^3.5.3", | |||
There was a problem hiding this comment.
I had locked typescript to 3.4.5 because of this issue:
microsoft/TypeScript#31722
There is indeed no impact on this project so let's move up the version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure to run the tests (including linter)
Tests and linter are intact, although there's no ts or d.ts linting yet.
Summary of proposed changes
tsconfig.jsonsince no compilation occurs aside fromtsdIssue
related to #13
How to test the changes
npm test