Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for Cross-Origin iFrame #439

Closed
wants to merge 1 commit into from
Closed

Conversation

Edweis
Copy link

@Edweis Edweis commented Feb 25, 2021

@github-actions github-actions bot added plugin: puppeteer-extra PuppeteerExtra Plugin related plugin: recaptcha 🏴 reCAPTCHA plugin related labels Feb 25, 2021
@berstend
Copy link
Owner

@Edweis do you know of any other way than to --disable-web-security? This is like a nuclear option of death, with many casualties along the way (e.g. any site will be able to fetch your facebook cookies as CORS is disabled). This can also be tested against.

@berstend
Copy link
Owner

berstend commented Mar 14, 2021

Isn't this sufficient?

      "--disable-features=IsolateOrigins,site-per-process",
      "--flag-switches-begin --disable-site-isolation-trials --flag-switches-end",

As per https://www.chromium.org/Home/chromium-security/site-isolation#TOC-Diagnosing-Issues

@berstend
Copy link
Owner

Related discussion: #196

Would be great if someone can make a proper test case to confirm failing behavior + fixed behavior when the two launch args are used. Also it'd be worthwhile to document negative side-effects - if they're neglectable we can make an evasion to enable that as the default.

@berstend
Copy link
Owner

berstend commented Jul 8, 2022

Love the followup and further explanation on this, one of the joys of maintaining open-source.

I took it upon myself to properly verify this and lo and behold this PR is nonsense:

image

const puppeteer = require("puppeteer")

puppeteer
  .launch({
    headless: false,
    args: [
      "--disable-features=IsolateOrigins,site-per-process,SitePerProcess",
      "--flag-switches-begin --disable-site-isolation-trials --flag-switches-end",
    ],
  })
  .then(async (browser) => {
    const page = await browser.newPage()
    await page.goto("chrome://process-internals/")
    await page.waitForTimeout(60 * 1000)
    await browser.close()
  })

Thanks!

@berstend berstend closed this Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: puppeteer-extra PuppeteerExtra Plugin related plugin: recaptcha 🏴 reCAPTCHA plugin related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants