Allow usage of self:: accessor for constants

ex: @annotation(self::VALUE) Fixes doctrine#269
bertrandseurot · Oct 2, 2020 · c3a707b · c3a707b
1 parent 2dceb19
commit c3a707b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/lib/Doctrine/Common/Annotations/AnnotationReader.php b/lib/Doctrine/Common/Annotations/AnnotationReader.php
@@ -331,7 +331,10 @@ private function collectParsingMetadata(ReflectionClass $class)
         $this->imports[$name] = array_merge(
             self::$globalImports,
             $this->phpParser->parseClass($class),
-            ['__NAMESPACE__' => $class->getNamespaceName()]
+            [
+                '__NAMESPACE__' => $class->getNamespaceName(),
+                'self' => $name,
+            ]
         );
 
         $this->ignoredAnnotationNames[$name] = $ignoredAnnotationNames;

diff --git a/tests/Doctrine/Tests/Common/Annotations/DocParserTest.php b/tests/Doctrine/Tests/Common/Annotations/DocParserTest.php
@@ -1005,6 +1005,20 @@ public function testSupportClassConstants(string $docblock, $expected): void
         self::assertEquals($expected, $annotation->value);
     }
 
+    public function testSupportSelfAccessorForClassConstants(): void
+    {
+        $parser    = $this->createTestParser();
+        $dockBlock = '@AnnotationWithConstants(self::SOME_VALUE)';
+        $parser->setImports([
+            'annotationwithconstants'   => AnnotationWithConstants::class,
+            'self'                      => ClassWithConstants::class,
+        ]);
+
+        $result = $parser->parse($dockBlock);
+        self::assertInstanceOf(AnnotationWithConstants::class, $annotation = $result[0]);
+        self::assertEquals(ClassWithConstants::SOME_VALUE, $annotation->value);
+    }
+
     public function testWithoutConstructorWhenIsNotDefaultValue(): void
     {
         $parser   = $this->createTestParser();