Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Auto js fixtures #3649

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP - Auto js fixtures #3649

wants to merge 2 commits into from

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Nov 10, 2021

Depends on #3650

The auto fixtures feature works but there will be problems with generating them consistently:

  • the dates will depend on run time
  • the identities are generated at run time
  • the events order is not guaranteed

I won't merge it for now because if it were used, it would require regenerating all snapshots on fixtures regen which would produce a lot of review noise and discourage snapshots diff reviews

@n0izn0iz n0izn0iz self-assigned this Nov 10, 2021
@n0izn0iz n0izn0iz requested review from moul and a team as code owners November 10, 2021 12:16
@trafico-bot trafico-bot bot added the 🚧 WIP label Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #3649 (f46b856) into master (3c55945) will decrease coverage by 0.02%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3649      +/-   ##
==========================================
- Coverage   29.84%   29.81%   -0.03%     
==========================================
  Files         378      378              
  Lines       32663    32679      +16     
  Branches     1752     1752              
==========================================
- Hits         9747     9744       -3     
- Misses      21642    21658      +16     
- Partials     1274     1277       +3     
Flag Coverage Δ
go.unittests 35.21% <11.76%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/internal/initutil/manager.go 73.15% <ø> (ø)
go/pkg/bertymessenger/service.go 39.36% <6.66%> (-1.96%) ⬇️
go/internal/initutil/node.go 42.35% <50.00%> (+0.59%) ⬆️
go/pkg/bertyaccount/service_account.go 52.12% <0.00%> (-0.34%) ⬇️
go/pkg/bertyprotocol/tinder_swiper.go 77.20% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c9c79...f46b856. Read the comment docs.

@n0izn0iz n0izn0iz changed the title WIP - Auto fixtures WIP - Auto fixtures and store refactor Nov 10, 2021
@n0izn0iz n0izn0iz changed the title WIP - Auto fixtures and store refactor WIP - Auto js fixtures Nov 10, 2021
Signed-off-by: Norman Meier <norman@berty.tech>
Signed-off-by: Norman Meier <norman@berty.tech>
@github-actions
Copy link

This PR/issue depends on:

@jefft0 jefft0 removed the request for review from moul March 23, 2023 09:37
@jefft0 jefft0 removed request for a team April 19, 2023 08:30
@jefft0 jefft0 removed the 🚧 WIP label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants