New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(messenger): don't dispatch useless member updates #3837
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3837 +/- ##
==========================================
- Coverage 29.88% 29.88% -0.01%
==========================================
Files 403 403
Lines 34205 34206 +1
Branches 1902 1903 +1
==========================================
Hits 10222 10222
- Misses 22665 22666 +1
Partials 1318 1318
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3412f68
to
f4e4e5b
Compare
Signed-off-by: Norman Meier <norman@berty.tech>
f4e4e5b
to
7ef1178
Compare
@jefft0 to ask if this is still relevant. |
n0izn0iz says: "This PR could still be relevant. This is an optimization so it doesn't trigger "state changes" and thus logic + rerenders in the front. But it's not very important I believe." |
Keep open because of the comment from n0izn0iz. Not a high priority, and not a bug. Put in draft. |
also wraps multiMemberGroupInitialMemberAnnounced handler in tx