Button detect mechanism in function whichMouseButton #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reserves witch button detect logic
Reserves the which button detect logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dragula is so great that lost of the libs refers. However some logic just drive me crazy, such as the button detect mechanism in function whichMouseButton. I found it at dragular and that make things not work at chrome ( 63.0.3239.84 64bit mac) & crosswalk 19+,so provides a change and thing goes will. However, today, few months later, I found the issue at another lib "ng2-dragular" and cause the same impacts, so maybe more libs would just refer dragula and may faces the same "problem".
Plz refer this discuss before and accept my pull request.
luckylooke/dragular#125
Thx & Great Job