Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specified toolchains for all jobs #3024

Closed
wants to merge 1 commit into from

Conversation

YohDeadfall
Copy link
Member

Objective

During work on #3009 I've found that not all jobs use actions-rs, and therefore, an previous version of Rust is used for them. So while compilation and other stuff can pass, checking markup and Android build may fail with compilation errors.

Solution

This PR takes changes made in #3009 (adds action-rs where needed) since it requires more work and time.

@MinerSebas
Copy link
Contributor

#2997 also adds actions-rs to more Jobs.

@YohDeadfall YohDeadfall deleted the fix-ci-tooling branch October 25, 2021 16:43
@mockersf
Copy link
Member

mockersf commented Oct 25, 2021

#2997 is on the pipelined-rendering branch, it would probably be useful to also have it on main and also fix the new rust lint there (pretty much cherry pick 28ec4bf and 959f268 from the pr to main)

@YohDeadfall
Copy link
Member Author

Do you mean that I can reopen the PR and provide all required fixes for main?

@mockersf
Copy link
Member

yes, please do

@YohDeadfall YohDeadfall restored the fix-ci-tooling branch October 26, 2021 07:58
@alice-i-cecile alice-i-cecile added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants