[Merged by Bors] - Fix KTX2 R8_SRGB, R8_UNORM, R8G8_SRGB, R8G8_UNORM, R8G8B8_SRGB, R8G8B8_UNORM support #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superdump
changed the title
alice-i-cecile
added
C-Bug
mockersf
approved these changes
May 4, 2022
|
@superdump how does this PR relate to #5325? (And this needs rebasing) |
atlv24
approved these changes
Jan 16, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
@alice-i-cecile it isn’t directly related. This is about supporting some uncompressed data formats. That other PR was rather about how to interpret the pieces of data (layers in array textures, faces in cubemap textures, both in cubemap array textures, and mip levels and whatever) to get them to wgpu buffers in the correct order without really caring about the format of the data itself. |
superdump
force-pushed
the
fix-ktx2-uncompressed
branch
from
70f0eca
to
52461b4
Compare
alice-i-cecile
approved these changes
Jan 30, 2023
mockersf
approved these changes
Jan 30, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 30, 2023
…8_UNORM support (#4594) # Objective - Fixes #4592 ## Solution - Implement `SrgbColorSpace` for `u8` via `f32` - Convert KTX2 R8 and R8G8 non-linear sRGB to wgpu `R8Unorm` and `Rg8Unorm` as non-linear sRGB are not supported by wgpu for these formats - Convert KTX2 R8G8B8 formats to `Rgba8Unorm` and `Rgba8UnormSrgb` by adding an alpha channel as the Rgb variants don't exist in wgpu --- ## Changelog - Added: Support for KTX2 `R8_SRGB`, `R8_UNORM`, `R8G8_SRGB`, `R8G8_UNORM`, `R8G8B8_SRGB`, `R8G8B8_UNORM` formats by converting to supported wgpu formats as appropriate
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…8_UNORM support (bevyengine#4594) # Objective - Fixes bevyengine#4592 ## Solution - Implement `SrgbColorSpace` for `u8` via `f32` - Convert KTX2 R8 and R8G8 non-linear sRGB to wgpu `R8Unorm` and `Rg8Unorm` as non-linear sRGB are not supported by wgpu for these formats - Convert KTX2 R8G8B8 formats to `Rgba8Unorm` and `Rgba8UnormSrgb` by adding an alpha channel as the Rgb variants don't exist in wgpu --- ## Changelog - Added: Support for KTX2 `R8_SRGB`, `R8_UNORM`, `R8G8_SRGB`, `R8G8_UNORM`, `R8G8B8_SRGB`, `R8G8B8_UNORM` formats by converting to supported wgpu formats as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
SrgbColorSpaceforu8viaf32R8UnormandRg8Unormas non-linear sRGB are not supported by wgpu for these formatsRgba8UnormandRgba8UnormSrgbby adding an alpha channel as the Rgb variants don't exist in wgpuChangelog
R8_SRGB,R8_UNORM,R8G8_SRGB,R8G8_UNORM,R8G8B8_SRGB,R8G8B8_UNORMformats by converting to supported wgpu formats as appropriate