[Merged by Bors] - Fix View by adding missing fields present in ViewUniform #5512

Azervu · 2022-07-31T14:37:01Z

Objective

View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields.

Solution

Solved by adding the fields in question

superdump · 2022-07-31T14:42:07Z

...oof. This should mean that Mesh2d is very broken in 0.8 unless I'm mistaken, or it's just luck that it isn't.

superdump

@cart I think we have our first candidate for a point release. :/

Azervu · 2022-07-31T14:47:41Z

That was quick, looks like the default rendering works because it only uses the first field.

cart · 2022-07-31T19:10:37Z

bors r+

# Objective View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields. ## Solution Solved by adding the fields in question

bors · 2022-07-31T19:31:24Z

Pull request successfully merged into main.

Build succeeded:

# Objective - Similar to #5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`. ## Solution - Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`

…5512) # Objective View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields. ## Solution Solved by adding the fields in question

# Objective View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields. ## Solution Solved by adding the fields in question

# Objective - Similar to #5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`. ## Solution - Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`

# Objective - Similar to bevyengine#5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`. ## Solution - Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`

…5512) # Objective View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields. ## Solution Solved by adding the fields in question

# Objective - Similar to bevyengine#5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`. ## Solution - Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`

…5512) # Objective View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields. ## Solution Solved by adding the fields in question

# Objective - Similar to bevyengine#5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`. ## Solution - Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`

Fix View by adding missing fields present in ViewUniform

ca69908

superdump added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Jul 31, 2022

superdump approved these changes Jul 31, 2022

View reviewed changes

cart added this to the Bevy 0.8.1 milestone Jul 31, 2022

bors bot changed the title ~~Fix View by adding missing fields present in ViewUniform~~ [Merged by Bors] - Fix View by adding missing fields present in ViewUniform Jul 31, 2022

bors bot closed this Jul 31, 2022

This was referenced Aug 1, 2022

[Merged by Bors] - Sync up bevy_sprite and bevy_ui shader View struct #5531

Closed

bevy_render: Centralize shader View uniform type #5535

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Fix View by adding missing fields present in ViewUniform #5512

[Merged by Bors] - Fix View by adding missing fields present in ViewUniform #5512

Azervu commented Jul 31, 2022

superdump commented Jul 31, 2022

superdump left a comment

Azervu commented Jul 31, 2022

cart commented Jul 31, 2022

bors bot commented Jul 31, 2022

[Merged by Bors] - Fix View by adding missing fields present in ViewUniform #5512

[Merged by Bors] - Fix View by adding missing fields present in ViewUniform #5512

Conversation

Azervu commented Jul 31, 2022

Objective

Solution

superdump commented Jul 31, 2022

superdump left a comment

Choose a reason for hiding this comment

Azervu commented Jul 31, 2022

cart commented Jul 31, 2022

bors bot commented Jul 31, 2022