Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add bevy_render::texture::ImageSettings to prelude #5566

Closed
wants to merge 1 commit into from

Conversation

Piturnah
Copy link
Contributor

@Piturnah Piturnah commented Aug 3, 2022

Objective

In Bevy 0.8, the default filter mode was changed to linear (#4465). I believe this is a sensible default, but it's also very common to want to use point filtering (e.g. for pixel art games).

Solution

I am proposing including bevy_render::texture::ImageSettings in the Bevy prelude so it is more ergonomic to change the filtering in such cases.


Changelog

Added

  • Added bevy_render::texture::ImageSettings to prelude.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use labels Aug 3, 2022
@Piturnah Piturnah requested a review from hymm August 3, 2022 17:28
@Piturnah
Copy link
Contributor Author

Piturnah commented Aug 3, 2022

I didn't mean to request a new review! Very sorry for the notification. Couldn't find a way to cancel it.

@Piturnah Piturnah changed the title Add bevy_render::texture::ImageSettings to prelude Add bevy_render::texture::ImageSettings to prelude Aug 4, 2022
@cart
Copy link
Member

cart commented Aug 4, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 4, 2022
# Objective

In Bevy 0.8, the default filter mode was changed to linear (#4465). I believe this is a sensible default, but it's also very common to want to use point filtering (e.g. for pixel art games). 

## Solution

I am proposing including `bevy_render::texture::ImageSettings` in the Bevy prelude so it is more ergonomic to change the filtering in such cases.

---

## Changelog

### Added
- Added `bevy_render::texture::ImageSettings` to prelude.
@bors bors bot changed the title Add bevy_render::texture::ImageSettings to prelude [Merged by Bors] - Add bevy_render::texture::ImageSettings to prelude Aug 4, 2022
@bors bors bot closed this Aug 4, 2022
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Aug 5, 2022
# Objective

In Bevy 0.8, the default filter mode was changed to linear (bevyengine#4465). I believe this is a sensible default, but it's also very common to want to use point filtering (e.g. for pixel art games). 

## Solution

I am proposing including `bevy_render::texture::ImageSettings` in the Bevy prelude so it is more ergonomic to change the filtering in such cases.

---

## Changelog

### Added
- Added `bevy_render::texture::ImageSettings` to prelude.
@Piturnah Piturnah deleted the update-prelude branch August 5, 2022 05:23
Piturnah added a commit to Piturnah/bevy that referenced this pull request Aug 5, 2022
bors bot pushed a commit that referenced this pull request Aug 6, 2022
# Objective

`bevy::render::texture::ImageSettings` was added to prelude in #5566, so these `use` statements are unnecessary and the examples can be made a bit more concise.

## Solution

Remove `use bevy::render::texture::ImageSettings`
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
# Objective

In Bevy 0.8, the default filter mode was changed to linear (bevyengine#4465). I believe this is a sensible default, but it's also very common to want to use point filtering (e.g. for pixel art games). 

## Solution

I am proposing including `bevy_render::texture::ImageSettings` in the Bevy prelude so it is more ergonomic to change the filtering in such cases.

---

## Changelog

### Added
- Added `bevy_render::texture::ImageSettings` to prelude.
inodentry pushed a commit to BroovyJammy/bevy that referenced this pull request Aug 19, 2022
# Objective

In Bevy 0.8, the default filter mode was changed to linear (bevyengine#4465). I believe this is a sensible default, but it's also very common to want to use point filtering (e.g. for pixel art games). 

## Solution

I am proposing including `bevy_render::texture::ImageSettings` in the Bevy prelude so it is more ergonomic to change the filtering in such cases.

---

## Changelog

### Added
- Added `bevy_render::texture::ImageSettings` to prelude.
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
# Objective

`bevy::render::texture::ImageSettings` was added to prelude in bevyengine#5566, so these `use` statements are unnecessary and the examples can be made a bit more concise.

## Solution

Remove `use bevy::render::texture::ImageSettings`
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

In Bevy 0.8, the default filter mode was changed to linear (bevyengine#4465). I believe this is a sensible default, but it's also very common to want to use point filtering (e.g. for pixel art games). 

## Solution

I am proposing including `bevy_render::texture::ImageSettings` in the Bevy prelude so it is more ergonomic to change the filtering in such cases.

---

## Changelog

### Added
- Added `bevy_render::texture::ImageSettings` to prelude.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

`bevy::render::texture::ImageSettings` was added to prelude in bevyengine#5566, so these `use` statements are unnecessary and the examples can be made a bit more concise.

## Solution

Remove `use bevy::render::texture::ImageSettings`
@Tarnadas
Copy link

Hey, the recent changelog of 0.9 suggests that ImageSettings is now in prelude, but ImageSettings no longer seems to exist

@Piturnah
Copy link
Contributor Author

Yep, it's been removed. Instead you should use .set(ImagePlugin::default_nearest()) on DefaultPlugins.

For example:

App::new()
    .add_plugins(
        DefaultPlugins.set(ImagePlugin::default_nearest())
    )
    .run();

ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

In Bevy 0.8, the default filter mode was changed to linear (bevyengine#4465). I believe this is a sensible default, but it's also very common to want to use point filtering (e.g. for pixel art games). 

## Solution

I am proposing including `bevy_render::texture::ImageSettings` in the Bevy prelude so it is more ergonomic to change the filtering in such cases.

---

## Changelog

### Added
- Added `bevy_render::texture::ImageSettings` to prelude.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

`bevy::render::texture::ImageSettings` was added to prelude in bevyengine#5566, so these `use` statements are unnecessary and the examples can be made a bit more concise.

## Solution

Remove `use bevy::render::texture::ImageSettings`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants