Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add into_world_mut to EntityMut #5586

Closed
wants to merge 1 commit into from

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Aug 5, 2022

Objective

Provide a safe API to access an EntityMut's World.

Solution

  • Add EntityMut::into_world_mut for safe access to the entity's world.

Changelog

  • Add EntityMut::into_world_mut for safe access to the entity's world.

@nicopap nicopap added A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use X-Controversial There is active debate or serious implications around merging this PR labels Aug 5, 2022
@nicopap nicopap requested a review from BoxyUwU August 5, 2022 18:46
@BoxyUwU
Copy link
Member

BoxyUwU commented Aug 7, 2022

(I'm not sure I agree this is S-Controversial 🤔)

@cart
Copy link
Member

cart commented Aug 8, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 8, 2022
# Objective

Provide a safe API to access an `EntityMut`'s `World`.

## Solution

* Add `EntityMut::into_world_mut` for safe access to the entity's world.

---

## Changelog

* Add `EntityMut::into_world_mut` for safe access to the entity's world.
@bors bors bot changed the title Add into_world_mut to EntityMut [Merged by Bors] - Add into_world_mut to EntityMut Aug 8, 2022
@bors bors bot closed this Aug 8, 2022
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
# Objective

Provide a safe API to access an `EntityMut`'s `World`.

## Solution

* Add `EntityMut::into_world_mut` for safe access to the entity's world.

---

## Changelog

* Add `EntityMut::into_world_mut` for safe access to the entity's world.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

Provide a safe API to access an `EntityMut`'s `World`.

## Solution

* Add `EntityMut::into_world_mut` for safe access to the entity's world.

---

## Changelog

* Add `EntityMut::into_world_mut` for safe access to the entity's world.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

Provide a safe API to access an `EntityMut`'s `World`.

## Solution

* Add `EntityMut::into_world_mut` for safe access to the entity's world.

---

## Changelog

* Add `EntityMut::into_world_mut` for safe access to the entity's world.
@nicopap nicopap deleted the entitymut-world branch September 20, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants