Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - use bevy_default() for texture format in post_processing #5601

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - use bevy_default() for texture format in post_processing #5601

wants to merge 1 commit into from
+2 −1

Conversation

contagnas
Copy link
Contributor

Objective

Fixes #5599

Solution

Use bevy_default() for texture format in example to get proper texture format for wasm.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Aug 7, 2022
@Vrixyz Vrixyz mentioned this pull request Aug 7, 2022
Closed
@cart
Copy link
Member

cart commented Aug 7, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 7, 2022
@contagnas
use bevy_default() for texture format in post_processing (#5601)
cd19d27 
# Objective

Fixes #5599

## Solution

Use bevy_default() for texture format in example to get proper texture format for wasm.
@bors
Copy link
Contributor

bors bot commented Aug 7, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title use bevy_default() for texture format in post_processing [Merged by Bors] - use bevy_default() for texture format in post_processing Aug 7, 2022
@bors bors bot closed this Aug 7, 2022
@contagnas contagnas deleted the post_processing_example_wasm branch August 7, 2022 21:37
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
@contagnas @maccesch
use bevy_default() for texture format in post_processing (bevyengine#…
29c2a23 
…5601)

# Objective

Fixes bevyengine#5599

## Solution

Use bevy_default() for texture format in example to get proper texture format for wasm.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@contagnas @james7132
use bevy_default() for texture format in post_processing (bevyengine#…
635d078 
…5601)

# Objective

Fixes bevyengine#5599

## Solution

Use bevy_default() for texture format in example to get proper texture format for wasm.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@contagnas @ItsDoot
use bevy_default() for texture format in post_processing (bevyengine#…
ba25036 
…5601)

# Objective

Fixes bevyengine#5599

## Solution

Use bevy_default() for texture format in example to get proper texture format for wasm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vrixyz Vrixyz

@jakobhellermann jakobhellermann

@DGriffin91 DGriffin91

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

post_processing example panics in wasm
6 participants
@contagnas @cart @Vrixyz @jakobhellermann @DGriffin91 @alice-i-cecile