Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - add some info from ReflectPathError to the error messages #5626

Closed

Conversation

jakobhellermann
Copy link
Contributor

Objective

  • The Display impl for ReflectPathError is pretty unspecific (e.g. the current struct doesn't have a field with the given name
  • it has info for better messages available

Solution

  • make the display impl more descriptive by including values from the type

Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A note that usually there would also be a list of expected token included, but that change would be more complex.

@alice-i-cecile alice-i-cecile added A-Reflection Runtime information about types A-Diagnostics Logging, crash handling, error reporting and performance analysis labels Aug 9, 2022
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Aug 9, 2022
# Objective

- The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name`
- it has info for better messages available

## Solution

- make the display impl more descriptive by including values from the type
@bors
Copy link
Contributor

bors bot commented Aug 9, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 9, 2022
# Objective

- The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name`
- it has info for better messages available

## Solution

- make the display impl more descriptive by including values from the type
@bors bors bot changed the title add some info from ReflectPathError to the error messages [Merged by Bors] - add some info from ReflectPathError to the error messages Aug 9, 2022
@bors bors bot closed this Aug 9, 2022
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
…ne#5626)

# Objective

- The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name`
- it has info for better messages available

## Solution

- make the display impl more descriptive by including values from the type
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…ne#5626)

# Objective

- The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name`
- it has info for better messages available

## Solution

- make the display impl more descriptive by including values from the type
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…ne#5626)

# Objective

- The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name`
- it has info for better messages available

## Solution

- make the display impl more descriptive by including values from the type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis A-Reflection Runtime information about types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants