[Merged by Bors] - remove ReflectMut in favor of Mut<dyn Reflect>
#5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
alice-i-cecile
approved these changes
Aug 9, 2022
PROMETHIA-27
approved these changes
Aug 9, 2022
alice-i-cecile
added
S-Ready-For-Final-Review
|
Technically breaking as bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
# Objective - `ReflectMut` served no purpose that wasn't met by `Mut<dyn Reflect>` which is easier to understand since you have to deal with fewer types - there is another `ReflectMut` type that could be confused with this one ## Solution/Changelog - relax `T: ?Sized` bound in `Mut<T>` - replace all instances of `ReflectMut` with `Mut<dyn Reflect>`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ReflectMut in favor of Mut<dyn Reflect>ReflectMut in favor of Mut<dyn Reflect>
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
# Objective - `ReflectMut` served no purpose that wasn't met by `Mut<dyn Reflect>` which is easier to understand since you have to deal with fewer types - there is another `ReflectMut` type that could be confused with this one ## Solution/Changelog - relax `T: ?Sized` bound in `Mut<T>` - replace all instances of `ReflectMut` with `Mut<dyn Reflect>`
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - `ReflectMut` served no purpose that wasn't met by `Mut<dyn Reflect>` which is easier to understand since you have to deal with fewer types - there is another `ReflectMut` type that could be confused with this one ## Solution/Changelog - relax `T: ?Sized` bound in `Mut<T>` - replace all instances of `ReflectMut` with `Mut<dyn Reflect>`
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…bevyengine#5993) # Objective - Fix disabling features in bevy_ecs (broken by bevyengine#5630) - Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
…bevyengine#5993) # Objective - Fix disabling features in bevy_ecs (broken by bevyengine#5630) - Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - `ReflectMut` served no purpose that wasn't met by `Mut<dyn Reflect>` which is easier to understand since you have to deal with fewer types - there is another `ReflectMut` type that could be confused with this one ## Solution/Changelog - relax `T: ?Sized` bound in `Mut<T>` - replace all instances of `ReflectMut` with `Mut<dyn Reflect>`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…bevyengine#5993) # Objective - Fix disabling features in bevy_ecs (broken by bevyengine#5630) - Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
ReflectMutserved no purpose that wasn't met byMut<dyn Reflect>which is easier to understand since you have to deal with fewer typesReflectMuttype that could be confused with this oneSolution/Changelog
T: ?Sizedbound inMut<T>ReflectMutwithMut<dyn Reflect>