Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - remove ReflectMut in favor of Mut<dyn Reflect> #5630

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - remove ReflectMut in favor of Mut<dyn Reflect> #5630

wants to merge 1 commit into from
+20 −28

Conversation

jakobhellermann
Copy link
Contributor

Objective

  • ReflectMut served no purpose that wasn't met by Mut<dyn Reflect> which is easier to understand since you have to deal with fewer types
  • there is another ReflectMut type that could be confused with this one

Solution/Changelog

  • relax T: ?Sized bound in Mut<T>
  • replace all instances of ReflectMut with Mut<dyn Reflect>

@jakobhellermann
remove ReflectMut in favor of Mut<dyn Reflect>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c922025
@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-Reflection Runtime information about types labels Aug 9, 2022
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Aug 9, 2022
@alice-i-cecile
Copy link
Member

Technically breaking as ReflectMut was pub.

bors r+

bors bot pushed a commit that referenced this pull request Aug 9, 2022
@jakobhellermann
remove ReflectMut in favor of Mut<dyn Reflect> (#5630)
fcb77d6 
# Objective

- `ReflectMut` served no purpose that wasn't met by `Mut<dyn Reflect>` which is easier to understand since you have to deal with fewer types
- there is another `ReflectMut` type that could be confused with this one

## Solution/Changelog

- relax `T: ?Sized` bound in `Mut<T>`
- replace all instances of `ReflectMut` with `Mut<dyn Reflect>`
@bors
Copy link
Contributor

bors bot commented Aug 9, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title remove ReflectMut in favor of Mut<dyn Reflect> [Merged by Bors] - remove ReflectMut in favor of Mut<dyn Reflect> Aug 9, 2022
@bors bors bot closed this Aug 9, 2022
@jakobhellermann jakobhellermann deleted the remove-reflect-mut branch August 10, 2022 13:12
@mockersf mockersf mentioned this pull request Sep 15, 2022
Closed
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
@jakobhellermann @maccesch
remove ReflectMut in favor of Mut<dyn Reflect> (bevyengine#5630)
19a9a4d 
# Objective

- `ReflectMut` served no purpose that wasn't met by `Mut<dyn Reflect>` which is easier to understand since you have to deal with fewer types
- there is another `ReflectMut` type that could be confused with this one

## Solution/Changelog

- relax `T: ?Sized` bound in `Mut<T>`
- replace all instances of `ReflectMut` with `Mut<dyn Reflect>`
bors bot pushed a commit that referenced this pull request Oct 24, 2022
@mockersf
Disabling default features support in bevy_ecs, bevy_reflect and bevy (…
64a8485 
…#5993)

# Objective

- Fix disabling features in bevy_ecs (broken by #5630)
- Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@jakobhellermann @james7132
remove ReflectMut in favor of Mut<dyn Reflect> (bevyengine#5630)
6c8fbd2 
# Objective

- `ReflectMut` served no purpose that wasn't met by `Mut<dyn Reflect>` which is easier to understand since you have to deal with fewer types
- there is another `ReflectMut` type that could be confused with this one

## Solution/Changelog

- relax `T: ?Sized` bound in `Mut<T>`
- replace all instances of `ReflectMut` with `Mut<dyn Reflect>`
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
Disabling default features support in bevy_ecs, bevy_reflect and bevy (…
ae3dbdc 
…bevyengine#5993)

# Objective

- Fix disabling features in bevy_ecs (broken by bevyengine#5630)
- Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
@mockersf @Pietrek14
Disabling default features support in bevy_ecs, bevy_reflect and bevy (…
4c5bfb3 
…bevyengine#5993)

# Objective

- Fix disabling features in bevy_ecs (broken by bevyengine#5630)
- Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@jakobhellermann @ItsDoot
remove ReflectMut in favor of Mut<dyn Reflect> (bevyengine#5630)
9011d23 
# Objective

- `ReflectMut` served no purpose that wasn't met by `Mut<dyn Reflect>` which is easier to understand since you have to deal with fewer types
- there is another `ReflectMut` type that could be confused with this one

## Solution/Changelog

- relax `T: ?Sized` bound in `Mut<T>`
- replace all instances of `ReflectMut` with `Mut<dyn Reflect>`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
Disabling default features support in bevy_ecs, bevy_reflect and bevy (…
342be38 
…bevyengine#5993)

# Objective

- Fix disabling features in bevy_ecs (broken by bevyengine#5630)
- Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile

@PROMETHIA-27 PROMETHIA-27

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakobhellermann @alice-i-cecile @PROMETHIA-27