Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - register Cow<'static, str> for reflection #5664

Closed
wants to merge 1 commit into from

Conversation

maccesch
Copy link
Contributor

Objective

Fixes #5597

Solution

Registered type at suggested place.

@maccesch maccesch changed the title register Cow<'static, str> for reflection register Cow<'static, str> for reflection Aug 13, 2022
@maccesch
Copy link
Contributor Author

@alice-i-cecile Weirdly the check that is failing is not at all connected to my code!

Copy link
Contributor

@BorisBoutillier BorisBoutillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI faliure is unrelated to this PR ( we need to merge #5665 first to fix CI).

@Weibye Weibye added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Reflection Runtime information about types C-Bug An unexpected or incorrect behavior labels Aug 13, 2022
@cart
Copy link
Member

cart commented Aug 16, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 16, 2022
# Objective

Fixes #5597

## Solution

Registered type at suggested place.
@bors bors bot changed the title register Cow<'static, str> for reflection [Merged by Bors] - register Cow<'static, str> for reflection Aug 16, 2022
@bors bors bot closed this Aug 16, 2022
inodentry pushed a commit to BroovyJammy/bevy that referenced this pull request Aug 19, 2022
# Objective

Fixes bevyengine#5597

## Solution

Registered type at suggested place.
maccesch added a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
# Objective

Fixes bevyengine#5597

## Solution

Registered type at suggested place.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

Fixes bevyengine#5597

## Solution

Registered type at suggested place.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

Fixes bevyengine#5597

## Solution

Registered type at suggested place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reflection Runtime information about types C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to serialize Name
6 participants