[Merged by Bors] - Correctly parse labels with '#' #5729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
approved these changes
Aug 18, 2022
mockersf
added
C-Bug
irate-devil
approved these changes
Aug 18, 2022
mockersf
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
# Objective - Fixes #5707 ## Solution - Used `splitn` instead of `split` to collect the rest of the string into the label after the first '#'. ---
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
inodentry
pushed a commit
to BroovyJammy/bevy
that referenced
this pull request
Aug 19, 2022
# Objective - Fixes bevyengine#5707 ## Solution - Used `splitn` instead of `split` to collect the rest of the string into the label after the first '#'. ---
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
# Objective - Fixes bevyengine#5707 ## Solution - Used `splitn` instead of `split` to collect the rest of the string into the label after the first '#'. ---
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Fixes bevyengine#5707 ## Solution - Used `splitn` instead of `split` to collect the rest of the string into the label after the first '#'. ---
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fixes bevyengine#5707 ## Solution - Used `splitn` instead of `split` to collect the rest of the string into the label after the first '#'. ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
splitninstead ofsplitto collect the rest of the string into the label after the first '#'.