Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add explicit ordering between update_frusta and camera_system #5757

Closed
wants to merge 1 commit into from

Conversation

TheRawMeatball
Copy link
Member

Objective

Fix a nasty system ordering bug between update_frusta and camera_system that lead to incorrect frustum s, leading to excessive culling and extremely hard-to-debug visual glitches

Solution

  • add explicit system ordering

@TheRawMeatball TheRawMeatball added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Aug 21, 2022
@cart cart requested a review from superdump August 22, 2022 23:08
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes perfect sense that we need to update the projection first and then update the frustum based on it. Good catch!

bors r+

bors bot pushed a commit that referenced this pull request Aug 23, 2022
)

# Objective

Fix a nasty system ordering bug between `update_frusta` and `camera_system` that lead to incorrect frustum s, leading to excessive culling and extremely hard-to-debug visual glitches

## Solution

- add explicit system ordering
@bors bors bot changed the title Add explicit ordering between update_frusta and camera_system [Merged by Bors] - Add explicit ordering between update_frusta and camera_system Aug 23, 2022
@bors bors bot closed this Aug 23, 2022
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
…vyengine#5757)

# Objective

Fix a nasty system ordering bug between `update_frusta` and `camera_system` that lead to incorrect frustum s, leading to excessive culling and extremely hard-to-debug visual glitches

## Solution

- add explicit system ordering
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…vyengine#5757)

# Objective

Fix a nasty system ordering bug between `update_frusta` and `camera_system` that lead to incorrect frustum s, leading to excessive culling and extremely hard-to-debug visual glitches

## Solution

- add explicit system ordering
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…vyengine#5757)

# Objective

Fix a nasty system ordering bug between `update_frusta` and `camera_system` that lead to incorrect frustum s, leading to excessive culling and extremely hard-to-debug visual glitches

## Solution

- add explicit system ordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants