Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add AUTO and UNDEFINED const constructors for Size #5761

Closed
wants to merge 2 commits into from

Conversation

Weibye
Copy link
Contributor

@Weibye Weibye commented Aug 21, 2022

Objective

Very small convenience constructors added to Size.

Does not change current examples too much but I'm working on a rather complex UI use-case where this cuts down on some extra typing :)

@Weibye Weibye added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A simple quality-of-life change that makes Bevy easier to use labels Aug 21, 2022
Copy link
Contributor

@TimJentzsch TimJentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. That are probably common patterns to use.

@Weibye Weibye added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 21, 2022
@cart
Copy link
Member

cart commented Aug 22, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 22, 2022
# Objective

Very small convenience constructors added to `Size`. 

Does not change current examples too much but I'm working on a rather complex UI use-case where this cuts down on some extra typing :)
@bors bors bot changed the title Add AUTO and UNDEFINED const constructors for Size [Merged by Bors] - Add AUTO and UNDEFINED const constructors for Size Aug 22, 2022
@bors bors bot closed this Aug 22, 2022
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
# Objective

Very small convenience constructors added to `Size`. 

Does not change current examples too much but I'm working on a rather complex UI use-case where this cuts down on some extra typing :)
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

Very small convenience constructors added to `Size`. 

Does not change current examples too much but I'm working on a rather complex UI use-case where this cuts down on some extra typing :)
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

Very small convenience constructors added to `Size`. 

Does not change current examples too much but I'm working on a rather complex UI use-case where this cuts down on some extra typing :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants