Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - bevy_reflect: GetTypeRegistration for SmallVec<T> #5782

Closed
wants to merge 1 commit into from

Conversation

MrGVSV
Copy link
Member

@MrGVSV MrGVSV commented Aug 24, 2022

Objective

SmallVec<T> was missing a GetTypeRegistration impl.

Solution

Added a GetTypeRegistration impl.


Changelog

  • Added a GetTypeRegistration impl for SmallVec<T>

@MrGVSV MrGVSV added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Aug 24, 2022
@MrGVSV MrGVSV force-pushed the reflect-smallvec-registration branch from 1261b95 to b307532 Compare August 24, 2022 06:39
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 24, 2022
@cart
Copy link
Member

cart commented Aug 24, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 24, 2022
# Objective

`SmallVec<T>` was missing a `GetTypeRegistration` impl.

## Solution

Added a `GetTypeRegistration` impl.

---

## Changelog

* Added a `GetTypeRegistration` impl for `SmallVec<T>`
@bors bors bot changed the title bevy_reflect: GetTypeRegistration for SmallVec<T> [Merged by Bors] - bevy_reflect: GetTypeRegistration for SmallVec<T> Aug 24, 2022
@bors bors bot closed this Aug 24, 2022
@MrGVSV MrGVSV deleted the reflect-smallvec-registration branch August 24, 2022 21:06
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
# Objective

`SmallVec<T>` was missing a `GetTypeRegistration` impl.

## Solution

Added a `GetTypeRegistration` impl.

---

## Changelog

* Added a `GetTypeRegistration` impl for `SmallVec<T>`
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

`SmallVec<T>` was missing a `GetTypeRegistration` impl.

## Solution

Added a `GetTypeRegistration` impl.

---

## Changelog

* Added a `GetTypeRegistration` impl for `SmallVec<T>`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

`SmallVec<T>` was missing a `GetTypeRegistration` impl.

## Solution

Added a `GetTypeRegistration` impl.

---

## Changelog

* Added a `GetTypeRegistration` impl for `SmallVec<T>`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reflection Runtime information about types C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants