Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update to notify 5.0 stable #5865

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Update to notify 5.0 stable #5865

wants to merge 2 commits into from

Conversation

Ixentus
Copy link
Contributor

@Ixentus Ixentus commented Sep 2, 2022

Objective

Solution

  • RecommendedWatcher now takes a Config argument. Giving it the default Config should be the same behavior as before (check every 30 seconds)

bjorn3
bjorn3 reviewed Sep 2, 2022
View reviewed changes
crates/bevy_asset/Cargo.toml Outdated Show resolved Hide resolved
@Ixentus @bjorn3
Update crates/bevy_asset/Cargo.toml
b7c5109 
Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
@mockersf mockersf added A-Assets Load files from disk to use for things like images, models, and sounds C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Sep 2, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 2, 2022
@Ixentus
Update to notify 5.0 stable (#5865)
17d84e8 
# Objective

- Update notify dependency to 5.0.0 stable
- Fix breaking changes
- Closes #5861

## Solution

- RecommendedWatcher now takes a Config argument. Giving it the default Config should be the same behavior as before (check every 30 seconds)
@bors
Copy link
Contributor

bors bot commented Sep 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update to notify 5.0 stable [Merged by Bors] - Update to notify 5.0 stable Sep 2, 2022
@bors bors bot closed this Sep 2, 2022
@Ixentus Ixentus deleted the notify5 branch September 2, 2022 16:55
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@Ixentus @james7132
Update to notify 5.0 stable (bevyengine#5865)
ae7c879 
# Objective

- Update notify dependency to 5.0.0 stable
- Fix breaking changes
- Closes bevyengine#5861

## Solution

- RecommendedWatcher now takes a Config argument. Giving it the default Config should be the same behavior as before (check every 30 seconds)
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@Ixentus @ItsDoot
Update to notify 5.0 stable (bevyengine#5865)
d1b2f52 
# Objective

- Update notify dependency to 5.0.0 stable
- Fix breaking changes
- Closes bevyengine#5861

## Solution

- RecommendedWatcher now takes a Config argument. Giving it the default Config should be the same behavior as before (check every 30 seconds)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ixentus @alice-i-cecile @mockersf @bjorn3