Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add ReflectAsset and ReflectHandle #5923

Closed
wants to merge 18 commits into from
Closed

[Merged by Bors] - add ReflectAsset and ReflectHandle #5923

wants to merge 18 commits into from

Commits on Oct 28, 2022

  1. add ReflectAsset and ReflectHandle

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    266f7b6 View commit details
    Browse the repository at this point in the history

  2. add register_asset_reflect function

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    de346a7 View commit details
    Browse the repository at this point in the history

  3. register assets as reflect: StandardMaterial, ColorMaterial, Animatio… 

    …nClip
    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    443e816 View commit details
    Browse the repository at this point in the history

  4. add len, ids and remove

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    b46db74 View commit details
    Browse the repository at this point in the history

  5. make Image reflect_value and register it as reflect asset

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    de862d8 View commit details
    Browse the repository at this point in the history

  6. tweak wording

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    26d5c61 View commit details
    Browse the repository at this point in the history

  7. add a test

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    467d1c2 View commit details
    Browse the repository at this point in the history

  8. add is_empty

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    cf44ca7 View commit details
    Browse the repository at this point in the history

  9. silence clippy

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    ab4822a View commit details
    Browse the repository at this point in the history

  10. expand docs

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    b2af704 View commit details
    Browse the repository at this point in the history

  11. add handle type id to ReflectAsset as well

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    d21c2f5 View commit details
    Browse the repository at this point in the history

  12. register texture atlas as reflect asset

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    d51bb6c View commit details
    Browse the repository at this point in the history

  13. add typed method

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    f862b37 View commit details
    Browse the repository at this point in the history

  14. Apply suggestions from code review 

    Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
    @jakobhellermann @MrGVSV
    jakobhellermann and MrGVSV committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    c511ba7 View commit details
    Browse the repository at this point in the history

  15. fix warnings and errors when compiling bevy_app with default_features… 

    … = false
    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    e4e93ee View commit details
    Browse the repository at this point in the history

  16. more review feedback

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    592e136 View commit details
    Browse the repository at this point in the history

  17. reflect(Debug)

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    48eb298 View commit details
    Browse the repository at this point in the history

  18. fix test

    @jakobhellermann
    jakobhellermann committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    51697dd View commit details
    Browse the repository at this point in the history