[Merged by Bors] - Implement Debug for dynamic types
#5948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irate-devil
approved these changes
Sep 11, 2022
NiklasEi
reviewed
Sep 12, 2022
I didn't take a look in all |
afonsolage
changed the title
Debug for DynamicEnum, DynamicTuple and DynamicVariantDebug for dynamic types
NiklasEi
approved these changes
Sep 12, 2022
NiklasEi
added
C-Usability
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
# Objective When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`. ## Solution Implement Debug for those types, using `derive` macro --- ## Changelog - `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
# Objective When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`. ## Solution Implement Debug for those types, using `derive` macro --- ## Changelog - `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
# Objective When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`. ## Solution Implement Debug for those types, using `derive` macro --- ## Changelog - `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Debug for dynamic typesDebug for dynamic types
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`. ## Solution Implement Debug for those types, using `derive` macro --- ## Changelog - `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`. ## Solution Implement Debug for those types, using `derive` macro --- ## Changelog - `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective When trying derive `Debug` for type that has `DynamicEnum` it wasn't possible, since neither of `DynamicEnum`, `DynamicTuple`, `DynamicVariant` or `DynamicArray` implements `Debug`. ## Solution Implement Debug for those types, using `derive` macro --- ## Changelog - `DynamicEnum`, `DynamicTuple`, `DynamicVariant` and `DynamicArray` now implements `Debug`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
When trying derive
Debugfor type that hasDynamicEnumit wasn't possible, since neither ofDynamicEnum,DynamicTuple,DynamicVariantorDynamicArrayimplementsDebug.Solution
Implement Debug for those types, using
derivemacroChangelog
DynamicEnum,DynamicTuple,DynamicVariantandDynamicArraynow implementsDebug