[Merged by Bors] - Make arrays behave like lists in reflection #5987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
reviewed
Sep 14, 2022
crates/bevy_reflect/src/path.rs
Outdated
Comment on lines
135
to
142
| let list_index = value.parse::<usize>()?; | ||
| let list_item = reflect_arr.get(list_index).ok_or( | ||
| ReflectPathError::InvalidListIndex { | ||
| index: current_index, | ||
| list_index, | ||
| }, | ||
| )?; | ||
| current = list_item; |
There was a problem hiding this comment.
Realistically, since List is a subtrait of Array, you should be able to extract this logic out and use it both lists and arrays.
There was a problem hiding this comment.
you are right, I missed that. Will rework.
There was a problem hiding this comment.
I was not able to combin the match branches themself, but move the inner logic in a function that accepts a &T where T: Array, which seems to work fine.
Is there a smarter way to do this?
There was a problem hiding this comment.
Nope that's how I'd do it!
Although, I’d actually use &(mut) dyn Array rather than T since we don't really have a true concrete type
There was a problem hiding this comment.
I tried that, but as far as I understand, we'd need feature(trait_upcasting) for that, right?
At least when I try it with this very simple example it fails in the same way: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9a17c93739790d86fd0f57a1452140c3
There was a problem hiding this comment.
Oh right haha then ignore what I suggested!
alice-i-cecile
added
A-Reflection
Since List is a supertrait of Array, we can treat both the same.
themasch
force-pushed
the
feat/reflection-arrays-and-lists
branch
from
f0ccb66
to
7cfa74e
Compare
MrGVSV
approved these changes
Sep 17, 2022
BorisBoutillier
approved these changes
Sep 23, 2022
rparrett
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 27, 2022
# Objective
Currently, arrays cannot indexed using the reflection path API.
This change makes them behave like lists so `x.get_path("list[0]")` will behave the same way, whether x.list is a "List" (e.g. a Vec) or an array.
## Solution
When syntax is encounterd `[ <idx> ]` we check if the referenced type is either a `ReflectRef::List` or `ReflectRef::Array` (or `ReflectMut` for the mutable case). Since both provide the identical API for accessing entries, we do the same for both, although it requires code duplication as far as I can tell.
This was born from working on #5764, but since this seems to be an easier fix (and I am not sure if I can actually solve #5812) I figured it might be worth to split this out.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective
Currently, arrays cannot indexed using the reflection path API.
This change makes them behave like lists so `x.get_path("list[0]")` will behave the same way, whether x.list is a "List" (e.g. a Vec) or an array.
## Solution
When syntax is encounterd `[ <idx> ]` we check if the referenced type is either a `ReflectRef::List` or `ReflectRef::Array` (or `ReflectMut` for the mutable case). Since both provide the identical API for accessing entries, we do the same for both, although it requires code duplication as far as I can tell.
This was born from working on bevyengine#5764, but since this seems to be an easier fix (and I am not sure if I can actually solve bevyengine#5812) I figured it might be worth to split this out.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective
Currently, arrays cannot indexed using the reflection path API.
This change makes them behave like lists so `x.get_path("list[0]")` will behave the same way, whether x.list is a "List" (e.g. a Vec) or an array.
## Solution
When syntax is encounterd `[ <idx> ]` we check if the referenced type is either a `ReflectRef::List` or `ReflectRef::Array` (or `ReflectMut` for the mutable case). Since both provide the identical API for accessing entries, we do the same for both, although it requires code duplication as far as I can tell.
This was born from working on bevyengine#5764, but since this seems to be an easier fix (and I am not sure if I can actually solve bevyengine#5812) I figured it might be worth to split this out.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective
Currently, arrays cannot indexed using the reflection path API.
This change makes them behave like lists so `x.get_path("list[0]")` will behave the same way, whether x.list is a "List" (e.g. a Vec) or an array.
## Solution
When syntax is encounterd `[ <idx> ]` we check if the referenced type is either a `ReflectRef::List` or `ReflectRef::Array` (or `ReflectMut` for the mutable case). Since both provide the identical API for accessing entries, we do the same for both, although it requires code duplication as far as I can tell.
This was born from working on bevyengine#5764, but since this seems to be an easier fix (and I am not sure if I can actually solve bevyengine#5812) I figured it might be worth to split this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Currently, arrays cannot indexed using the reflection path API.
This change makes them behave like lists so
x.get_path("list[0]")will behave the same way, whether x.list is a "List" (e.g. a Vec) or an array.Solution
When syntax is encounterd
[ <idx> ]we check if the referenced type is either aReflectRef::ListorReflectRef::Array(orReflectMutfor the mutable case). Since both provide the identical API for accessing entries, we do the same for both, although it requires code duplication as far as I can tell.This was born from working on #5764, but since this seems to be an easier fix (and I am not sure if I can actually solve #5812) I figured it might be worth to split this out.