[Merged by Bors] - Derived `Copy` trait for `bevy_input` events, `Serialize`/`Deserialize` for events in `bevy_input` and `bevy_windows`, `PartialEq` for events in both, and `Eq` where possible in both. #6023

targrub · 2022-09-19T18:52:47Z

Objective

Add traits to events in bevy_input and bevy_windows: Copy, Serialize/Deserialize, PartialEq, and Eq, as requested in #6022, #6023, #6024.

Solution

Added the traits to events in bevy_input and bevy_windows. Added dependency of serde in Cargo.toml of bevy_input.

Migration Guide

If one has been .clone()'ing bevy_input events, Clippy will now complain about that. Just remove .clone() to solve.

Other Notes

Some events in bevy_input had f32 fields, so Eq trait was not derived for them.
Some events in bevy_windows had String fields, so Copy trait was not derived for them.

…_window.

…vents in bevy_input. Added PartialEq trait to bevy_input events without it.

crates/bevy_window/Cargo.toml

…erde an optional dependency. Added conditional #derives for necessary types in bevy_window.

mockersf · 2022-09-19T21:49:58Z

now you need to add bevy_window/serialize to

bevy/crates/bevy_internal/Cargo.toml

Line 48 in 28205fd

serialize = ["bevy_input/serialize"]

crates/bevy_window/src/event.rs

alice-i-cecile

All the bevy_window events need PartialEq impls :) The general strategy LGTM now though.

… structure fields.

…r and its structs.

alice-i-cecile

Awesome, LGTM now!

Test serialization of Bevy's `Duration`, not `std::time::Duration`.

targrub · 2022-09-20T16:44:46Z

This PR's code should have ended with 29ebbd9

bzm3r

Looks good to me! I just have one question.

bzm3r · 2022-09-20T17:47:45Z

crates/bevy_window/src/event.rs

@@ -4,7 +4,8 @@ use super::{WindowDescriptor, WindowId};
 use bevy_math::{IVec2, Vec2};

 /// A window event that is sent whenever a window's logical size has changed.
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, PartialEq)]


Is it possible to derive Copy for the items in this file?

A number of them have String or PathBuf fields, so Copy cannot be derived for those.

bzm3r · 2022-09-20T17:52:29Z

Is it worth deriving Hash too, right now, or should that be left for a separate issue? For bevy_input items in particular, I can see that being useful.

EDIT: nvm, just saw this: #6024 (comment)

bzm3r

Looks good to me! (Leaving an actual approval this time!)

alice-i-cecile · 2022-09-20T18:13:15Z

bors r+

…e` for events in `bevy_input` and `bevy_windows`, `PartialEq` for events in both, and `Eq` where possible in both. (#6023) # Objective Add traits to events in `bevy_input` and `bevy_windows`: `Copy`, `Serialize`/`Deserialize`, `PartialEq`, and `Eq`, as requested in #6022, #6023, #6024. ## Solution Added the traits to events in `bevy_input` and `bevy_windows`. Added dependency of `serde` in `Cargo.toml` of `bevy_input`. ## Migration Guide If one has been `.clone()`'ing `bevy_input` events, Clippy will now complain about that. Just remove `.clone()` to solve. ## Other Notes Some events in `bevy_input` had `f32` fields, so `Eq` trait was not derived for them. Some events in `bevy_windows` had `String` fields, so `Copy` trait was not derived for them. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>

bors · 2022-09-20T18:18:22Z

Build failed:

build (ubuntu-latest)

alice-i-cecile · 2022-09-20T18:23:42Z

Flaky failure, see #6036

bors retry

…e` for events in `bevy_input` and `bevy_windows`, `PartialEq` for events in both, and `Eq` where possible in both. (#6023) # Objective Add traits to events in `bevy_input` and `bevy_windows`: `Copy`, `Serialize`/`Deserialize`, `PartialEq`, and `Eq`, as requested in #6022, #6023, #6024. ## Solution Added the traits to events in `bevy_input` and `bevy_windows`. Added dependency of `serde` in `Cargo.toml` of `bevy_input`. ## Migration Guide If one has been `.clone()`'ing `bevy_input` events, Clippy will now complain about that. Just remove `.clone()` to solve. ## Other Notes Some events in `bevy_input` had `f32` fields, so `Eq` trait was not derived for them. Some events in `bevy_windows` had `String` fields, so `Copy` trait was not derived for them. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>

bors · 2022-09-20T18:44:07Z

Pull request successfully merged into main.

Build succeeded:

…e` for events in `bevy_input` and `bevy_windows`, `PartialEq` for events in both, and `Eq` where possible in both. (bevyengine#6023) Add traits to events in `bevy_input` and `bevy_windows`: `Copy`, `Serialize`/`Deserialize`, `PartialEq`, and `Eq`, as requested in bevyengine#6022, bevyengine#6023, bevyengine#6024. Added the traits to events in `bevy_input` and `bevy_windows`. Added dependency of `serde` in `Cargo.toml` of `bevy_input`. If one has been `.clone()`'ing `bevy_input` events, Clippy will now complain about that. Just remove `.clone()` to solve. Some events in `bevy_input` had `f32` fields, so `Eq` trait was not derived for them. Some events in `bevy_windows` had `String` fields, so `Copy` trait was not derived for them. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>

…e` for events in `bevy_input` and `bevy_windows`, `PartialEq` for events in both, and `Eq` where possible in both. (bevyengine#6023) # Objective Add traits to events in `bevy_input` and `bevy_windows`: `Copy`, `Serialize`/`Deserialize`, `PartialEq`, and `Eq`, as requested in bevyengine#6022, bevyengine#6023, bevyengine#6024. ## Solution Added the traits to events in `bevy_input` and `bevy_windows`. Added dependency of `serde` in `Cargo.toml` of `bevy_input`. ## Migration Guide If one has been `.clone()`'ing `bevy_input` events, Clippy will now complain about that. Just remove `.clone()` to solve. ## Other Notes Some events in `bevy_input` had `f32` fields, so `Eq` trait was not derived for them. Some events in `bevy_windows` had `String` fields, so `Copy` trait was not derived for them. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>

targrub added 3 commits September 19, 2022 14:46

Derived Copy trait for bevy_input events.

f36fc4b

Added serde::Serialize/Deserialize under "serialize" feature for bevy…

e684d79

…_window.

Add serde::Serialize/Deserialize traits via "serialize" feature for e…

be401d6

…vents in bevy_input. Added PartialEq trait to bevy_input events without it.

targrub changed the title ~~Derived Copy trait for bevy_input events.~~ Derived Copy trait for bevy_input events, Serialize/Deserialize for events in bevy_input and bevy_windows, PartialEq for events in both, and Eq where possible in both. Sep 19, 2022

mockersf reviewed Sep 19, 2022

View reviewed changes

crates/bevy_window/Cargo.toml Outdated Show resolved Hide resolved

Added the serialize feature into bevy_window's Cargo.toml, and made s…

644dca0

…erde an optional dependency. Added conditional #derives for necessary types in bevy_window.

Added "bevy_window/serialize" to serialize=[ ... ] set.

617ee6c

alice-i-cecile added A-Input Player input via keyboard, mouse, gamepad, and more A-Windowing Platform-agnostic interface layer to run your app in C-Usability A simple quality-of-life change that makes Bevy easier to use labels Sep 20, 2022

alice-i-cecile mentioned this pull request Sep 20, 2022

Make bevy_scene dependency on serde optional #6030

Closed

alice-i-cecile reviewed Sep 20, 2022

View reviewed changes

crates/bevy_window/src/event.rs Outdated Show resolved Hide resolved

alice-i-cecile reviewed Sep 20, 2022

View reviewed changes

crates/bevy_window/src/event.rs Outdated Show resolved Hide resolved

alice-i-cecile requested changes Sep 20, 2022

View reviewed changes

targrub and others added 3 commits September 19, 2022 21:19

Added PartialEq trait to bevy_window events, WindowDescriptor and its…

815cccd

… structure fields.

Added Eq trait where possible to bevy_windows events, WindowDescripto…

1994230

…r and its structs.

Merge branch 'bevyengine:main' into main

29ebbd9

alice-i-cecile approved these changes Sep 20, 2022

View reviewed changes

alice-i-cecile added this to the Bevy 0.9 milestone Sep 20, 2022

targrub and others added 2 commits September 20, 2022 08:56

Test serialization of Bevy's Duration, not std::time::Duration.

807fbcf

Merge pull request #1 from targrub/Test-Duration-rather-than-std-version

29b1d3f

Test serialization of Bevy's `Duration`, not `std::time::Duration`.

bzm3r reviewed Sep 20, 2022

View reviewed changes

alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 20, 2022

bzm3r approved these changes Sep 20, 2022

View reviewed changes

bors bot closed this Sep 20, 2022

alice-i-cecile mentioned this pull request Oct 2, 2022

Add serialization and deserialization support Leafwing-Studios/leafwing_input_playback#11

Closed

alice-i-cecile mentioned this pull request Oct 13, 2022

[Merged by Bors] - Add default implementation of Serialize and Deserialize to Timer and Stopwatch #6248

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Derived `Copy` trait for `bevy_input` events, `Serialize`/`Deserialize` for events in `bevy_input` and `bevy_windows`, `PartialEq` for events in both, and `Eq` where possible in both. #6023

[Merged by Bors] - Derived `Copy` trait for `bevy_input` events, `Serialize`/`Deserialize` for events in `bevy_input` and `bevy_windows`, `PartialEq` for events in both, and `Eq` where possible in both. #6023

targrub commented Sep 19, 2022 •

edited

mockersf commented Sep 19, 2022

alice-i-cecile left a comment

alice-i-cecile left a comment

targrub commented Sep 20, 2022

bzm3r left a comment

bzm3r Sep 20, 2022

targrub Sep 20, 2022

bzm3r commented Sep 20, 2022 •

edited

bzm3r left a comment

alice-i-cecile commented Sep 20, 2022

bors bot commented Sep 20, 2022

alice-i-cecile commented Sep 20, 2022

bors bot commented Sep 20, 2022

[Merged by Bors] - Derived Copy trait for bevy_input events, Serialize/Deserialize for events in bevy_input and bevy_windows, PartialEq for events in both, and Eq where possible in both. #6023

[Merged by Bors] - Derived Copy trait for bevy_input events, Serialize/Deserialize for events in bevy_input and bevy_windows, PartialEq for events in both, and Eq where possible in both. #6023

Conversation

targrub commented Sep 19, 2022 • edited

Objective

Solution

Migration Guide

Other Notes

mockersf commented Sep 19, 2022

alice-i-cecile left a comment

Choose a reason for hiding this comment

alice-i-cecile left a comment

Choose a reason for hiding this comment

targrub commented Sep 20, 2022

bzm3r left a comment

Choose a reason for hiding this comment

bzm3r Sep 20, 2022

Choose a reason for hiding this comment

targrub Sep 20, 2022

Choose a reason for hiding this comment

bzm3r commented Sep 20, 2022 • edited

bzm3r left a comment

Choose a reason for hiding this comment

alice-i-cecile commented Sep 20, 2022

bors bot commented Sep 20, 2022

alice-i-cecile commented Sep 20, 2022

bors bot commented Sep 20, 2022

[Merged by Bors] - Derived `Copy` trait for `bevy_input` events, `Serialize`/`Deserialize` for events in `bevy_input` and `bevy_windows`, `PartialEq` for events in both, and `Eq` where possible in both. #6023

[Merged by Bors] - Derived `Copy` trait for `bevy_input` events, `Serialize`/`Deserialize` for events in `bevy_input` and `bevy_windows`, `PartialEq` for events in both, and `Eq` where possible in both. #6023

targrub commented Sep 19, 2022 •

edited

bzm3r commented Sep 20, 2022 •

edited