[Merged by Bors] - Add getters and setters for InputAxis and ButtonSettings
#6088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
positive_high => livezone_upperbound positive_low => deadzone_upperbound negative_low => deadzone_lowerbound negative_high => livezone_lowerbound
alice-i-cecile
added
A-Input
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
afonsolage
suggested changes
Sep 29, 2022
Co-authored-by: Afonso Lage <lage.afonso@gmail.com>
Co-authored-by: Afonso Lage <lage.afonso@gmail.com>
An attempt to comply with Rust API Guidelines.
|
I've taken a look at the docs, and I'm quite happy with how they are :) |
mockersf
reviewed
Oct 5, 2022
mockersf
reviewed
Oct 5, 2022
mockersf
reviewed
Oct 5, 2022
Co-authored-by: François <mockersf@gmail.com>
Other minor fixes to threshold docs.
Split `GamepadSettingsError` error into two enums, `ButtonSettingsError` and `AxisSettingsError`.
Added more tests. Fixed docstrings.
mockersf
reviewed
Oct 5, 2022
alice-i-cecile
approved these changes
Oct 5, 2022
targrub
commented
Oct 11, 2022
|
@afonsolage Any doc changes you'd like to make? |
bzm3r
approved these changes
Oct 17, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Merging! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
# Objective Fixes #3418 ## Solution Originally a rebase of #3446. Work was originally done by mfdorst, who should receive considerable credit. Then the error types were extensively reworked by targrub. ## Migration Guide `AxisSettings` now has a `new()`, which may return an `AxisSettingsError`. `AxisSettings` fields made private; now must be accessed through getters and setters. There's a dead zone, from `.deadzone_upperbound()` to `.deadzone_lowerbound()`, and a live zone, from `.deadzone_upperbound()` to `.livezone_upperbound()` and from `.deadzone_lowerbound()` to `.livezone_lowerbound()`. `AxisSettings` setters no longer panic. `ButtonSettings` fields made private; now must be accessed through getters and setters. `ButtonSettings` now has a `new()`, which may return a `ButtonSettingsError`. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
InputAxis and ButtonSettingsInputAxis and ButtonSettings
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
…ine#6088) # Objective Fixes bevyengine#3418 ## Solution Originally a rebase of bevyengine#3446. Work was originally done by mfdorst, who should receive considerable credit. Then the error types were extensively reworked by targrub. ## Migration Guide `AxisSettings` now has a `new()`, which may return an `AxisSettingsError`. `AxisSettings` fields made private; now must be accessed through getters and setters. There's a dead zone, from `.deadzone_upperbound()` to `.deadzone_lowerbound()`, and a live zone, from `.deadzone_upperbound()` to `.livezone_upperbound()` and from `.deadzone_lowerbound()` to `.livezone_lowerbound()`. `AxisSettings` setters no longer panic. `ButtonSettings` fields made private; now must be accessed through getters and setters. `ButtonSettings` now has a `new()`, which may return a `ButtonSettingsError`. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>
ickk
added
the
C-Breaking-Change
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…ine#6088) # Objective Fixes bevyengine#3418 ## Solution Originally a rebase of bevyengine#3446. Work was originally done by mfdorst, who should receive considerable credit. Then the error types were extensively reworked by targrub. ## Migration Guide `AxisSettings` now has a `new()`, which may return an `AxisSettingsError`. `AxisSettings` fields made private; now must be accessed through getters and setters. There's a dead zone, from `.deadzone_upperbound()` to `.deadzone_lowerbound()`, and a live zone, from `.deadzone_upperbound()` to `.livezone_upperbound()` and from `.deadzone_lowerbound()` to `.livezone_lowerbound()`. `AxisSettings` setters no longer panic. `ButtonSettings` fields made private; now must be accessed through getters and setters. `ButtonSettings` now has a `new()`, which may return a `ButtonSettingsError`. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
…ine#6088) # Objective Fixes bevyengine#3418 ## Solution Originally a rebase of bevyengine#3446. Work was originally done by mfdorst, who should receive considerable credit. Then the error types were extensively reworked by targrub. ## Migration Guide `AxisSettings` now has a `new()`, which may return an `AxisSettingsError`. `AxisSettings` fields made private; now must be accessed through getters and setters. There's a dead zone, from `.deadzone_upperbound()` to `.deadzone_lowerbound()`, and a live zone, from `.deadzone_upperbound()` to `.livezone_upperbound()` and from `.deadzone_lowerbound()` to `.livezone_lowerbound()`. `AxisSettings` setters no longer panic. `ButtonSettings` fields made private; now must be accessed through getters and setters. `ButtonSettings` now has a `new()`, which may return a `ButtonSettingsError`. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…ine#6088) # Objective Fixes bevyengine#3418 ## Solution Originally a rebase of bevyengine#3446. Work was originally done by mfdorst, who should receive considerable credit. Then the error types were extensively reworked by targrub. ## Migration Guide `AxisSettings` now has a `new()`, which may return an `AxisSettingsError`. `AxisSettings` fields made private; now must be accessed through getters and setters. There's a dead zone, from `.deadzone_upperbound()` to `.deadzone_lowerbound()`, and a live zone, from `.deadzone_upperbound()` to `.livezone_upperbound()` and from `.deadzone_lowerbound()` to `.livezone_lowerbound()`. `AxisSettings` setters no longer panic. `ButtonSettings` fields made private; now must be accessed through getters and setters. `ButtonSettings` now has a `new()`, which may return a `ButtonSettingsError`. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #3418
Solution
Originally a rebase of #3446. Work was originally done by mfdorst, who should receive considerable credit. Then the error types were extensively reworked by targrub.
Migration Guide
AxisSettingsnow has anew(), which may return anAxisSettingsError.AxisSettingsfields made private; now must be accessed through getters and setters. There's a dead zone, from.deadzone_upperbound()to.deadzone_lowerbound(), and a live zone, from.deadzone_upperbound()to.livezone_upperbound()and from.deadzone_lowerbound()to.livezone_lowerbound().AxisSettingssetters no longer panic.ButtonSettingsfields made private; now must be accessed through getters and setters.ButtonSettingsnow has anew(), which may return aButtonSettingsError.