[Merged by Bors] - Make raw_window_handle field in Window and ExtractedWindow an Option.
#6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hain_texture() accessor.
Window::raw_window_handle() now returns Option<RawWindowHandleWrapper>.
|
Incorporates #6110 code changes. Its PR documentation should be considered a part of this PR's documentation. Therefore, its Migration Guide should be added with this PR's. |
alice-i-cecile
added
A-Windowing
Nilirad
added
the
C-Breaking-Change
Also added derive for PartialEq trait on WindowCommand.
alice-i-cecile
approved these changes
Oct 5, 2022
|
This LGTM now. This is overall a very small change that will make testing this code much easier, for both users and the engine. |
mockersf
reviewed
Oct 13, 2022
MDeiml
reviewed
Oct 14, 2022
MDeiml
approved these changes
Oct 15, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
…Option`. (#6114) # Objective - Trying to make it possible to do write tests that don't require a raw window handle. - Fixes #6106. ## Solution - Make the interface and type changes. Avoid accessing `None`. --- ## Changelog - Converted `raw_window_handle` field in both `Window` and `ExtractedWindow` to `Option<RawWindowHandleWrapper>`. - Revised accessor function `Window::raw_window_handle()` to return `Option<RawWindowHandleWrapper>`. - Skip conditions in loops that would require a raw window handle (to create a `Surface`, for example). ## Migration Guide `Window::raw_window_handle()` now returns `Option<RawWindowHandleWrapper>`. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
raw_window_handle field in Window and ExtractedWindow an Option.raw_window_handle field in Window and ExtractedWindow an Option.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
…Option`. (bevyengine#6114) # Objective - Trying to make it possible to do write tests that don't require a raw window handle. - Fixes bevyengine#6106. ## Solution - Make the interface and type changes. Avoid accessing `None`. --- ## Changelog - Converted `raw_window_handle` field in both `Window` and `ExtractedWindow` to `Option<RawWindowHandleWrapper>`. - Revised accessor function `Window::raw_window_handle()` to return `Option<RawWindowHandleWrapper>`. - Skip conditions in loops that would require a raw window handle (to create a `Surface`, for example). ## Migration Guide `Window::raw_window_handle()` now returns `Option<RawWindowHandleWrapper>`. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…Option`. (bevyengine#6114) # Objective - Trying to make it possible to do write tests that don't require a raw window handle. - Fixes bevyengine#6106. ## Solution - Make the interface and type changes. Avoid accessing `None`. --- ## Changelog - Converted `raw_window_handle` field in both `Window` and `ExtractedWindow` to `Option<RawWindowHandleWrapper>`. - Revised accessor function `Window::raw_window_handle()` to return `Option<RawWindowHandleWrapper>`. - Skip conditions in loops that would require a raw window handle (to create a `Surface`, for example). ## Migration Guide `Window::raw_window_handle()` now returns `Option<RawWindowHandleWrapper>`. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
…Option`. (bevyengine#6114) # Objective - Trying to make it possible to do write tests that don't require a raw window handle. - Fixes bevyengine#6106. ## Solution - Make the interface and type changes. Avoid accessing `None`. --- ## Changelog - Converted `raw_window_handle` field in both `Window` and `ExtractedWindow` to `Option<RawWindowHandleWrapper>`. - Revised accessor function `Window::raw_window_handle()` to return `Option<RawWindowHandleWrapper>`. - Skip conditions in loops that would require a raw window handle (to create a `Surface`, for example). ## Migration Guide `Window::raw_window_handle()` now returns `Option<RawWindowHandleWrapper>`. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…Option`. (bevyengine#6114) # Objective - Trying to make it possible to do write tests that don't require a raw window handle. - Fixes bevyengine#6106. ## Solution - Make the interface and type changes. Avoid accessing `None`. --- ## Changelog - Converted `raw_window_handle` field in both `Window` and `ExtractedWindow` to `Option<RawWindowHandleWrapper>`. - Revised accessor function `Window::raw_window_handle()` to return `Option<RawWindowHandleWrapper>`. - Skip conditions in loops that would require a raw window handle (to create a `Surface`, for example). ## Migration Guide `Window::raw_window_handle()` now returns `Option<RawWindowHandleWrapper>`. Co-authored-by: targrub <62773321+targrub@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
WindowandWindowsstructs easier to test with #6106.Solution
None.Changelog
raw_window_handlefield in bothWindowandExtractedWindowtoOption<RawWindowHandleWrapper>.Window::raw_window_handle()to returnOption<RawWindowHandleWrapper>.Surface, for example).Migration Guide
Window::raw_window_handle()now returnsOption<RawWindowHandleWrapper>.