[Merged by Bors] - Register Wireframe type
#6152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irate-devil
approved these changes
Oct 3, 2022
MrGVSV
approved these changes
Oct 3, 2022
mockersf
approved these changes
Oct 3, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
# Objective The `Wireframe` type implements `Reflect`, but is never registered, making its reflection inaccessible. ## Solution Call `App::register_type::<Wireframe>()` in the `Plugin::build` implementation of `WireframePlugin`. --- ## Changelog Fixed `Wireframe` type reflection not getting registered.
mockersf
added
C-Usability
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Wireframe typeWireframe type
mockersf
added
the
hacktoberfest-accepted
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective The `Wireframe` type implements `Reflect`, but is never registered, making its reflection inaccessible. ## Solution Call `App::register_type::<Wireframe>()` in the `Plugin::build` implementation of `WireframePlugin`. --- ## Changelog Fixed `Wireframe` type reflection not getting registered.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective The `Wireframe` type implements `Reflect`, but is never registered, making its reflection inaccessible. ## Solution Call `App::register_type::<Wireframe>()` in the `Plugin::build` implementation of `WireframePlugin`. --- ## Changelog Fixed `Wireframe` type reflection not getting registered.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective The `Wireframe` type implements `Reflect`, but is never registered, making its reflection inaccessible. ## Solution Call `App::register_type::<Wireframe>()` in the `Plugin::build` implementation of `WireframePlugin`. --- ## Changelog Fixed `Wireframe` type reflection not getting registered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The
Wireframetype implementsReflect, but is never registered, making its reflection inaccessible.Solution
Call
App::register_type::<Wireframe>()in thePlugin::buildimplementation ofWireframePlugin.Changelog
Fixed
Wireframetype reflection not getting registered.