Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fixes Camera not being serializable due to missing registrations in core functionality. #6170

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Fixes Camera not being serializable due to missing registrations in core functionality. #6170

wants to merge 4 commits into from

Conversation

NoahShomette
Copy link
Contributor

…

Objective

Solution

  • Updated Bevy_Render CameraPlugin with registrations for Option and then Bevy_Core CorePlugin with registrations for ReflectSerialize and ReflectDeserialize for type data Range respectively according to the solution in Register missing types for Camera #6169

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen A-Reflection Runtime information about types labels Oct 5, 2022
alice-i-cecile
alice-i-cecile approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you take this out of draft I'll merge it as trivial :)

@NoahShomette
Copy link
Contributor Author

If you take this out of draft I'll merge it as trivial :)

Thanks lol, they are talking about other alternate solutions on the issue page here: #6169. I'm happy to take it out of draft however I'm not sure which solution is the better one and that discussion hasn't exactly ended yet

@NoahShomette NoahShomette marked this pull request as ready for review October 7, 2022 00:59
MrGVSV
MrGVSV approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@MrGVSV MrGVSV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine to merge for now. The discussion in #6169 can be handled in another PR (specifically Range reflection).

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 8, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 10, 2022
@NoahShomette
Fixes Camera not being serializable due to missing registrations in c…
6ae46f6 
…ore functionality. (#6170)

…

# Objective

- Fixes Camera not being serializable due to missing registrations in core functionality. 
- Fixes #6169

## Solution

- Updated Bevy_Render CameraPlugin with registrations for Option<Viewport> and then Bevy_Core CorePlugin with registrations for ReflectSerialize and ReflectDeserialize for type data Range<f32> respectively according to the solution in #6169



Co-authored-by: Noah <noahshomette@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 10, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fixes Camera not being serializable due to missing registrations in core functionality. [Merged by Bors] - Fixes Camera not being serializable due to missing registrations in core functionality. Oct 10, 2022
@bors bors bot closed this Oct 10, 2022
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 10, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
@NoahShomette @james7132
Fixes Camera not being serializable due to missing registrations in c…
3abfbc8 
…ore functionality. (bevyengine#6170)

…

# Objective

- Fixes Camera not being serializable due to missing registrations in core functionality. 
- Fixes bevyengine#6169

## Solution

- Updated Bevy_Render CameraPlugin with registrations for Option<Viewport> and then Bevy_Core CorePlugin with registrations for ReflectSerialize and ReflectDeserialize for type data Range<f32> respectively according to the solution in bevyengine#6169



Co-authored-by: Noah <noahshomette@gmail.com>
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@NoahShomette @james7132
Fixes Camera not being serializable due to missing registrations in c…
7b93442 
…ore functionality. (bevyengine#6170)

…

# Objective

- Fixes Camera not being serializable due to missing registrations in core functionality. 
- Fixes bevyengine#6169

## Solution

- Updated Bevy_Render CameraPlugin with registrations for Option<Viewport> and then Bevy_Core CorePlugin with registrations for ReflectSerialize and ReflectDeserialize for type data Range<f32> respectively according to the solution in bevyengine#6169



Co-authored-by: Noah <noahshomette@gmail.com>
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
@NoahShomette @Pietrek14
Fixes Camera not being serializable due to missing registrations in c…
fd81340 
…ore functionality. (bevyengine#6170)

…

# Objective

- Fixes Camera not being serializable due to missing registrations in core functionality. 
- Fixes bevyengine#6169

## Solution

- Updated Bevy_Render CameraPlugin with registrations for Option<Viewport> and then Bevy_Core CorePlugin with registrations for ReflectSerialize and ReflectDeserialize for type data Range<f32> respectively according to the solution in bevyengine#6169



Co-authored-by: Noah <noahshomette@gmail.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@NoahShomette @ItsDoot
Fixes Camera not being serializable due to missing registrations in c…
4d1c3d1 
…ore functionality. (bevyengine#6170)

…

# Objective

- Fixes Camera not being serializable due to missing registrations in core functionality. 
- Fixes bevyengine#6169

## Solution

- Updated Bevy_Render CameraPlugin with registrations for Option<Viewport> and then Bevy_Core CorePlugin with registrations for ReflectSerialize and ReflectDeserialize for type data Range<f32> respectively according to the solution in bevyengine#6169



Co-authored-by: Noah <noahshomette@gmail.com>
@NoahShomette NoahShomette deleted the register_missing_types_for_camera branch February 16, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

@jakobhellermann jakobhellermann Awaiting requested review from jakobhellermann

Assignees
No one assigned
Labels
A-Reflection Runtime information about types A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Register missing types for Camera
4 participants
@NoahShomette @alice-i-cecile @MrGVSV @mockersf