Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make bevy_window and bevy_input events serializable #6180

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Make bevy_window and bevy_input events serializable #6180

wants to merge 1 commit into from

Conversation

emersonmx
Copy link
Contributor

Closes #6021

alice-i-cecile
alice-i-cecile approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as trivial, thanks!

bors r+

@alice-i-cecile alice-i-cecile added A-Windowing Platform-agnostic interface layer to run your app in C-Usability A simple quality-of-life change that makes Bevy easier to use labels Oct 6, 2022
bors bot pushed a commit that referenced this pull request Oct 6, 2022
@emersonmx
Make bevy_window and bevy_input events serializable (#6180)
087f1c6 
Closes #6021
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 6, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 6, 2022
@alice-i-cecile
Copy link
Member

I'm going to leave the linked issue open, as there's still more work to do on touch inputs :)

@bors
Copy link
Contributor

bors bot commented Oct 6, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make bevy_window and bevy_input events serializable [Merged by Bors] - Make bevy_window and bevy_input events serializable Oct 6, 2022
@bors bors bot closed this Oct 6, 2022
@emersonmx emersonmx deleted the add-serialize-to-events branch October 7, 2022 00:20
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
@emersonmx @james7132
Make bevy_window and bevy_input events serializable (bevyengine#6180)
c56af14 
Closes bevyengine#6021
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@emersonmx @james7132
Make bevy_window and bevy_input events serializable (bevyengine#6180)
7c2ad80 
Closes bevyengine#6021
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@emersonmx @ItsDoot
Make bevy_window and bevy_input events serializable (bevyengine#6180)
ee33398 
Closes bevyengine#6021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Usability A simple quality-of-life change that makes Bevy easier to use hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make bevy_window and bevy_input events serializable
3 participants
@emersonmx @alice-i-cecile @mockersf