Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Impl Reflect for PathBuf and OsString #6193

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Impl Reflect for PathBuf and OsString #6193

wants to merge 1 commit into from

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Oct 7, 2022

Objective

Reflect impl is missing for PathBuf and OsString. Closes #6166.

Solution

Add implementations.

Changelog

Added

Reflect impls for PathBuf and OsString.

@Shatur Shatur marked this pull request as draft October 7, 2022 19:36
@alice-i-cecile alice-i-cecile added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Oct 7, 2022
@Shatur Shatur marked this pull request as ready for review October 7, 2022 21:25
@Shatur
Copy link
Contributor Author

Shatur commented Oct 7, 2022

@alice-i-cecile I added implementation for OsString only on platforms that can serialize it as in serde.

@alice-i-cecile
Copy link
Member

Great, thanks for the context there. Can you add that as a comment?

@Shatur
Copy link
Contributor Author

Shatur commented Oct 7, 2022

Done!

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 7, 2022
tguichaoua
tguichaoua suggested changes Oct 8, 2022
View reviewed changes
Copy link
Contributor

@tguichaoua tguichaoua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think feature = "std" is used in serde because it's a no_std crate. It's not necessary here.

crates/bevy_reflect/src/impls/std.rs Outdated Show resolved Hide resolved
crates/bevy_reflect/src/impls/std.rs Outdated Show resolved Hide resolved
@Shatur
Copy link
Contributor Author

Shatur commented Oct 8, 2022

Of course, thanks, fixed.

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 8, 2022
@Shatur
Impl Reflect for PathBuf and OsString (#6193)
ca3e6e6 
# Objective

`Reflect` impl is missing for `PathBuf` and `OsString`. Closes #6166.

## Solution

Add implementations.

---

## Changelog

### Added

`Reflect` impls for `PathBuf` and `OsString`.
@bors
Copy link
Contributor

bors bot commented Oct 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Impl Reflect for PathBuf and OsString [Merged by Bors] - Impl Reflect for PathBuf and OsString Oct 8, 2022
@bors bors bot closed this Oct 8, 2022
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 8, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
@Shatur @james7132
Impl Reflect for PathBuf and OsString (bevyengine#6193)
8b8df09 
# Objective

`Reflect` impl is missing for `PathBuf` and `OsString`. Closes bevyengine#6166.

## Solution

Add implementations.

---

## Changelog

### Added

`Reflect` impls for `PathBuf` and `OsString`.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@Shatur @james7132
Impl Reflect for PathBuf and OsString (bevyengine#6193)
5fea4c3 
# Objective

`Reflect` impl is missing for `PathBuf` and `OsString`. Closes bevyengine#6166.

## Solution

Add implementations.

---

## Changelog

### Added

`Reflect` impls for `PathBuf` and `OsString`.
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
@Shatur @Pietrek14
Impl Reflect for PathBuf and OsString (bevyengine#6193)
6f2498e 
# Objective

`Reflect` impl is missing for `PathBuf` and `OsString`. Closes bevyengine#6166.

## Solution

Add implementations.

---

## Changelog

### Added

`Reflect` impls for `PathBuf` and `OsString`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@Shatur @ItsDoot
Impl Reflect for PathBuf and OsString (bevyengine#6193)
06f7f6f 
# Objective

`Reflect` impl is missing for `PathBuf` and `OsString`. Closes bevyengine#6166.

## Solution

Add implementations.

---

## Changelog

### Added

`Reflect` impls for `PathBuf` and `OsString`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@tguichaoua tguichaoua tguichaoua approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Usability A simple quality-of-life change that makes Bevy easier to use hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Reflect for PathBuf and OsString
5 participants
@Shatur @alice-i-cecile @tguichaoua @MrGVSV @mockersf