[Merged by Bors] - Call mesh2d_tangent_local_to_world with the right arguments
#6209
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superdump
approved these changes
Oct 9, 2022
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Oct 9, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 9, 2022
# Objective Allow `Mesh2d` shaders to work with meshes that have vertex tangents ## Solution Correctly pass `mesh.model` into `mesh2d_tangent_local_to_world`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
mesh2d_tangent_local_to_world with the right argumentsmesh2d_tangent_local_to_world with the right arguments
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
…gine#6209) # Objective Allow `Mesh2d` shaders to work with meshes that have vertex tangents ## Solution Correctly pass `mesh.model` into `mesh2d_tangent_local_to_world`
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…gine#6209) # Objective Allow `Mesh2d` shaders to work with meshes that have vertex tangents ## Solution Correctly pass `mesh.model` into `mesh2d_tangent_local_to_world`
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
…gine#6209) # Objective Allow `Mesh2d` shaders to work with meshes that have vertex tangents ## Solution Correctly pass `mesh.model` into `mesh2d_tangent_local_to_world`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…gine#6209) # Objective Allow `Mesh2d` shaders to work with meshes that have vertex tangents ## Solution Correctly pass `mesh.model` into `mesh2d_tangent_local_to_world`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow
Mesh2dshaders to work with meshes that have vertex tangentsSolution
Correctly pass
mesh.modelintomesh2d_tangent_local_to_world