Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - dynamic scene builder #6227

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - dynamic scene builder #6227

wants to merge 5 commits into from

Conversation

mockersf
Copy link
Member

Objective

  • make it easier to build dynamic scenes

Solution

@mockersf mockersf added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Scenes Serialized ECS data stored on the disk labels Oct 10, 2022
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Oct 10, 2022 •
edited

I like this approach much better than either of the other linked PRs. It composes better, and provides an excellent foundation. I'm going to close the others in favor of this.

This was referenced Oct 10, 2022
Closed
Closed
alice-i-cecile
alice-i-cecile requested changes Oct 10, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obligatory doc nits. Once those are fixed up, this has my approval.

mockersf and others added 2 commits October 11, 2022 00:57
@mockersf @alice-i-cecile
doc
919a65e 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@mockersf
flatten ze iterator
d4f4244
MrGVSV
MrGVSV approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@MrGVSV MrGVSV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits. Nothing blocking I don't think, though. Looks good!

crates/bevy_scene/src/dynamic_scene_builder.rs Show resolved Hide resolved
crates/bevy_scene/src/dynamic_scene_builder.rs Show resolved Hide resolved
crates/bevy_scene/src/dynamic_scene_builder.rs Outdated Show resolved Hide resolved
crates/bevy_scene/src/dynamic_scene_builder.rs Show resolved Hide resolved
@mockersf @MrGVSV
less nesting
f30bc4c 
Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 10, 2022
@alice-i-cecile alice-i-cecile added this to the Bevy 0.9 milestone Oct 10, 2022
@alice-i-cecile
Copy link
Member

Giving this a day or two to attract reviews, then merging it unless there are other complaints.

@alice-i-cecile
Copy link
Member

The oven timer's gone off, this things is adequately baked 🥖

bors r+

bors bot pushed a commit that referenced this pull request Oct 12, 2022
@mockersf
dynamic scene builder (#6227)
ccf7c65 
# Objective

- make it easier to build dynamic scenes

## Solution

- add a builder to create a dynamic scene from a world. it can extract an entity or an iterator of entities
- alternative to #6013, leaving the "hierarchy iteration" part to #6185 which does it better
- alternative to #6004 
- using a builder makes it easier to chain several extractions
@bors
Copy link
Contributor

bors bot commented Oct 12, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title dynamic scene builder [Merged by Bors] - dynamic scene builder Oct 12, 2022
@bors bors bot closed this Oct 12, 2022
@mockersf mockersf mentioned this pull request Oct 12, 2022
Closed
ramirezmike added a commit to ramirezmike/bevy that referenced this pull request Oct 13, 2022
@ramirezmike
Updated DynamicScene to use iter_entities (bevyengine#6227)
288629b
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 13, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
@mockersf @james7132
dynamic scene builder (bevyengine#6227)
2cb24a9 
# Objective

- make it easier to build dynamic scenes

## Solution

- add a builder to create a dynamic scene from a world. it can extract an entity or an iterator of entities
- alternative to bevyengine#6013, leaving the "hierarchy iteration" part to bevyengine#6185 which does it better
- alternative to bevyengine#6004 
- using a builder makes it easier to chain several extractions
@ickk ickk mentioned this pull request Oct 27, 2022
Closed
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
dynamic scene builder (bevyengine#6227)
fba90f5 
# Objective

- make it easier to build dynamic scenes

## Solution

- add a builder to create a dynamic scene from a world. it can extract an entity or an iterator of entities
- alternative to bevyengine#6013, leaving the "hierarchy iteration" part to bevyengine#6185 which does it better
- alternative to bevyengine#6004 
- using a builder makes it easier to chain several extractions
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
@mockersf @Pietrek14
dynamic scene builder (bevyengine#6227)
5a97550 
# Objective

- make it easier to build dynamic scenes

## Solution

- add a builder to create a dynamic scene from a world. it can extract an entity or an iterator of entities
- alternative to bevyengine#6013, leaving the "hierarchy iteration" part to bevyengine#6185 which does it better
- alternative to bevyengine#6004 
- using a builder makes it easier to chain several extractions
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
dynamic scene builder (bevyengine#6227)
46488cb 
# Objective

- make it easier to build dynamic scenes

## Solution

- add a builder to create a dynamic scene from a world. it can extract an entity or an iterator of entities
- alternative to bevyengine#6013, leaving the "hierarchy iteration" part to bevyengine#6185 which does it better
- alternative to bevyengine#6004 
- using a builder makes it easier to chain several extractions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-Scenes Serialized ECS data stored on the disk C-Usability A simple quality-of-life change that makes Bevy easier to use hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
Bevy 0.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mockersf @alice-i-cecile @MrGVSV