Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - use bevy default texture format if the surface is not yet available #6233

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - use bevy default texture format if the surface is not yet available #6233

wants to merge 4 commits into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • In case no supported format is found, try to use Bevy default instead of panicking

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen P-High This is particularly urgent, and deserves immediate attention labels Oct 11, 2022
@alice-i-cecile alice-i-cecile added this to the Bevy 0.9 milestone Oct 11, 2022
@inodentry
Copy link
Contributor

Confirmed working on macOS on M1 Pro. :) 👍

@alice-i-cecile
Copy link
Member

Thanks for testing this out for me.

bors r+

bors bot pushed a commit that referenced this pull request Oct 11, 2022
@mockersf
use bevy default texture format if the surface is not yet available (#…
13dcdba 
…6233)

# Objective

- Fix #6231

## Solution

- In case no supported format is found, try to use Bevy default instead of panicking
@bors
Copy link
Contributor

bors bot commented Oct 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title use bevy default texture format if the surface is not yet available [Merged by Bors] - use bevy default texture format if the surface is not yet available Oct 11, 2022
@bors bors bot closed this Oct 11, 2022
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 11, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
@mockersf @james7132
use bevy default texture format if the surface is not yet available (b…
52915e1 
…evyengine#6233)

# Objective

- Fix bevyengine#6231

## Solution

- In case no supported format is found, try to use Bevy default instead of panicking
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
use bevy default texture format if the surface is not yet available (b…
6b954b0 
…evyengine#6233)

# Objective

- Fix bevyengine#6231

## Solution

- In case no supported format is found, try to use Bevy default instead of panicking
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
@mockersf @Pietrek14
use bevy default texture format if the surface is not yet available (b…
c30b7be 
…evyengine#6233)

# Objective

- Fix bevyengine#6231

## Solution

- In case no supported format is found, try to use Bevy default instead of panicking
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
use bevy default texture format if the surface is not yet available (b…
fa978e6 
…evyengine#6233)

# Objective

- Fix bevyengine#6231

## Solution

- In case no supported format is found, try to use Bevy default instead of panicking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event P-High This is particularly urgent, and deserves immediate attention
Projects
None yet
Milestone
Bevy 0.9
Development

Successfully merging this pull request may close these issues.

index out of bounds when running any Bevy example
3 participants
@mockersf @inodentry @alice-i-cecile