Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add Eq & PartialEq to AssetPath #6274

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add Eq & PartialEq to AssetPath #6274

wants to merge 1 commit into from

Conversation

zmarlon
Copy link
Contributor

@zmarlon zmarlon commented Oct 16, 2022

Adds Eq and ArtialEq to AssetPath to make AssetPath usable inside HashMaps.

@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Oct 16, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 17, 2022
@zmarlon
Add Eq & PartialEq to AssetPath (#6274)
bfd6285 
Adds `Eq` and `ArtialEq` to `AssetPath` to make `AssetPath` usable inside HashMaps.
@bors
Copy link
Contributor

bors bot commented Oct 17, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add Eq & PartialEq to AssetPath [Merged by Bors] - Add Eq & PartialEq to AssetPath Oct 17, 2022
@bors bors bot closed this Oct 17, 2022
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 17, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
@zmarlon @james7132
Add Eq & PartialEq to AssetPath (bevyengine#6274)
0b5cc68 
Adds `Eq` and `ArtialEq` to `AssetPath` to make `AssetPath` usable inside HashMaps.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@zmarlon @james7132
Add Eq & PartialEq to AssetPath (bevyengine#6274)
aaffffd 
Adds `Eq` and `ArtialEq` to `AssetPath` to make `AssetPath` usable inside HashMaps.
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
@zmarlon @Pietrek14
Add Eq & PartialEq to AssetPath (bevyengine#6274)
1b2ef77 
Adds `Eq` and `ArtialEq` to `AssetPath` to make `AssetPath` usable inside HashMaps.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@zmarlon @ItsDoot
Add Eq & PartialEq to AssetPath (bevyengine#6274)
109463d 
Adds `Eq` and `ArtialEq` to `AssetPath` to make `AssetPath` usable inside HashMaps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@irate-devil irate-devil irate-devil approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Usability A simple quality-of-life change that makes Bevy easier to use hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zmarlon @alice-i-cecile @james7132 @irate-devil @mockersf