[Merged by Bors] - Update clap requirement from 3.2 to 4.0 #6303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [clap](https://github.com/clap-rs/clap) to permit the latest version. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v3.2.0...v4.0.8) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
alice-i-cecile
approved these changes
Oct 19, 2022
alice-i-cecile
added
the
C-Dependencies
mockersf
approved these changes
Oct 19, 2022
mockersf
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
# Objective Alternative to #6150 Dependabot's PR doesn't seem to break anything, but there are some deprecations that we might as well fix up. ## Solution https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#migrating Update clap in `build-wasm-example` and `span-cmp`. Other tools don't use clap. Remove references to `value_parser`. It's the default now. Change `#[clap()]` to `#[arg()]`. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
TimJentzsch
approved these changes
Oct 19, 2022
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
mockersf
added
the
hacktoberfest-accepted
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Alternative to bevyengine#6150 Dependabot's PR doesn't seem to break anything, but there are some deprecations that we might as well fix up. ## Solution https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#migrating Update clap in `build-wasm-example` and `span-cmp`. Other tools don't use clap. Remove references to `value_parser`. It's the default now. Change `#[clap()]` to `#[arg()]`. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
# Objective Alternative to bevyengine#6150 Dependabot's PR doesn't seem to break anything, but there are some deprecations that we might as well fix up. ## Solution https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#migrating Update clap in `build-wasm-example` and `span-cmp`. Other tools don't use clap. Remove references to `value_parser`. It's the default now. Change `#[clap()]` to `#[arg()]`. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Alternative to bevyengine#6150 Dependabot's PR doesn't seem to break anything, but there are some deprecations that we might as well fix up. ## Solution https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#migrating Update clap in `build-wasm-example` and `span-cmp`. Other tools don't use clap. Remove references to `value_parser`. It's the default now. Change `#[clap()]` to `#[arg()]`. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Alternative to #6150
Dependabot's PR doesn't seem to break anything, but there are some deprecations that we might as well fix up.
Solution
https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#migrating
Update clap in
build-wasm-exampleandspancmp. Other tools don't use clap.Remove references to
value_parser. It's the default now.Change
#[clap()]to#[arg()].