Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - better wording for time scaling docs #6340

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - better wording for time scaling docs #6340

wants to merge 3 commits into from

Conversation

maniwani
Copy link
Contributor

@maniwani maniwani commented Oct 22, 2022 •
edited

Quick follow-up to #5752. I think this is a slightly better wording.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Time Involves time keeping and reporting labels Oct 22, 2022
dataphract
dataphract approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@dataphract dataphract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a minor style comment -- the content looks good!

crates/bevy_time/src/time.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 22, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 24, 2022
@maniwani
better wording for time scaling docs (#6340)
1d22634 
Quick follow-up to #5752. I think this is a slightly better wording.
@bors
Copy link
Contributor

bors bot commented Oct 24, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title better wording for time scaling docs [Merged by Bors] - better wording for time scaling docs Oct 24, 2022
@bors bors bot closed this Oct 24, 2022
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 24, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@maniwani @james7132
better wording for time scaling docs (bevyengine#6340)
18e60ff 
Quick follow-up to bevyengine#5752. I think this is a slightly better wording.
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
@maniwani @Pietrek14
better wording for time scaling docs (bevyengine#6340)
fb0055a 
Quick follow-up to bevyengine#5752. I think this is a slightly better wording.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@maniwani @ItsDoot
better wording for time scaling docs (bevyengine#6340)
b37ecf6 
Quick follow-up to bevyengine#5752. I think this is a slightly better wording.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@dataphract dataphract dataphract approved these changes

Assignees
No one assigned
Labels
A-Time Involves time keeping and reporting C-Docs An addition or correction to our documentation hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maniwani @alice-i-cecile @dataphract @mockersf